Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect.vue: error on onToggleAll and bad default placeholder #45

Closed
jonasraoni opened this issue Aug 29, 2019 · 1 comment
Closed

MultiSelect.vue: error on onToggleAll and bad default placeholder #45

jonasraoni opened this issue Aug 29, 2019 · 1 comment
Assignees
@Merve7
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
1.0.0-beta.9

Comments

@jonasraoni
Copy link

When triggering the onToggleAll, the function isn't applying the getOptionValue to the items, which cause different outcomes than when selecting all by hand.
Also, when there's no placeholder it defaults to p-multiselect.
jonasraoni pushed a commit to jonasraoni/primevue that referenced this issue Aug 29, 2019
primefaces#45 Modified the onToggleAll to keep the same behavior of s…
b5d325d 
…electing all items by hand and replaced default placeholder.
jonasraoni pushed a commit to jonasraoni/primevue that referenced this issue Aug 30, 2019
primefaces#45 Modified the onToggleAll to keep the same behavior of s…
15d2c8b 
…electing all items by hand and replaced default placeholder.
@Merve7
Copy link
Contributor

Merve7 commented Sep 23, 2019

Thank you for your pull request. We have another solution. You can check after release. If the problem still persists please let me know again.

@Merve7 Merve7 self-assigned this Sep 23, 2019
@Merve7 Merve7 added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 23, 2019
@Merve7 Merve7 added this to the 1.0.0-beta.9 milestone Sep 23, 2019
@Merve7 Merve7 closed this as completed in c76a5de Sep 23, 2019
tugcekucukoglu pushed a commit that referenced this issue Nov 18, 2024
@navedqb
Merge pull request #45 from navedqb/fix--6795
7613b6e 
fix: prevent text cursor and typing in colorpicker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merve7 Merve7

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
1.0.0-beta.9
Development

No branches or pull requests
2 participants
@jonasraoni @Merve7