Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar: Icon classes not being correctly exposed #4303

Closed
Magiczne opened this issue Aug 21, 2023 · 0 comments
Closed

Sidebar: Icon classes not being correctly exposed #4303

Magiczne opened this issue Aug 21, 2023 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
3.32.2

Comments

@Magiczne
Copy link
Contributor

Magiczne commented Aug 21, 2023 •
edited
Loading

Describe the bug

Similar to #4264, #4301 and #4302

This time when trying to overwrite close icon there is no way to add p-sidebar-close-icon via slot as the slot is not exposing this class.

Yes - it can be done manually, but to keep consistency with other components the slot should expose this class. And for easier potential future changes in library.

Reproducer

https://codesandbox.io/p/sandbox/cranky-cookies-7wddpn

PrimeVue version

3.32.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Magiczne Magiczne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 21, 2023
@Magiczne Magiczne mentioned this issue Aug 21, 2023
Closed
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 23, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.32.2 milestone Aug 23, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 23, 2023
@tugcekucukoglu tugcekucukoglu added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 23, 2023
This was referenced Aug 31, 2023
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
3.32.2
Development

No branches or pull requests
2 participants
@Magiczne @tugcekucukoglu