Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Accessibility features broken when hour-format="12" #4287

Closed
zachlearnscode opened this issue Aug 17, 2023 · 0 comments · Fixed by #4356
Closed

Calendar: Accessibility features broken when hour-format="12" #4287

zachlearnscode opened this issue Aug 17, 2023 · 0 comments · Fixed by #4356
Assignees
@bahadirsofuoglu
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.33.0

Comments

@zachlearnscode
Copy link

Describe the bug

The accessibility features built in to the Calendar input don't work when hour-format="12".

In particular, the focus trap is broken and selecting a date with space or enter does not close the popup.

The features appear to work as expected with show-time="true", then break when hour-format is applied.

See CodeSandbox.

Reproducer

https://codesandbox.io/s/relaxed-silence-v5v46f?file=/src/App.vue

PrimeVue version

^3.9.1

Vue version

3.x

Language

ES6

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@zachlearnscode zachlearnscode added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 17, 2023
@zachlearnscode zachlearnscode changed the title Calendar: Accessibility feature broken when hour-format="12" Calendar: Accessibility features broken when hour-format="12" Aug 17, 2023
@bahadirsofuoglu bahadirsofuoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 30, 2023
@bahadirsofuoglu bahadirsofuoglu self-assigned this Aug 30, 2023
@bahadirsofuoglu bahadirsofuoglu added this to the 3.32.3 milestone Aug 30, 2023
@bahadirsofuoglu bahadirsofuoglu mentioned this issue Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahadirsofuoglu bahadirsofuoglu

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.33.0
Development

Successfully merging a pull request may close this issue.

Calendar: format 12 container focustrap issue primefaces/primevue
2 participants
@bahadirsofuoglu @zachlearnscode