Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectButton: passthrough option #4286

Closed
Rakasch opened this issue Aug 17, 2023 · 3 comments
Closed

SelectButton: passthrough option #4286

Rakasch opened this issue Aug 17, 2023 · 3 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@Rakasch
Copy link
Contributor

Rakasch commented Aug 17, 2023

Describe the feature you would like to see added

I want to add tooltips to the buttons.
Since each button has it's own tooltip, I have the tooltip within the options.
eg.
image

I want to use passthrough to add those tooltips to the buttons.
But currently the passthrough context only contains the buttons active and disabled state.
I need access to the buttons option data from the passthrough context.

This would also allow a lot more custom configuration depending on each button's state.

Is your feature request related to a problem?

No response

Describe the solution you'd like

add the blue line of code to Selectbutton.vue
image

Describe alternatives you have considered

No response

Additional context

No response

@Rakasch Rakasch added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Aug 17, 2023
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Aug 17, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.32.1 milestone Aug 17, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 17, 2023
@tugcekucukoglu
Copy link
Member

buttons inside the SelectButton have no tooltip pt options but Tooltip directive has its own pt implementation.

@Feher-Zsofia
Copy link

Feher-Zsofia commented Nov 7, 2023

The Tooltip directive can't set the tooltip of each of the buttons, it only works within the template part (where the item is accessible). Is this the intended solution for this problem?
@tugcekucukoglu Do you have any input on this?

@Rakasch
Copy link
Contributor Author

Rakasch commented Nov 7, 2023

I thought I could use pt for this, but unfortunately not.
No idea. I ended up making a local copy of the SelectButton component and added support for a tooltip in each option myself.
Tooltips on each button are quite mandatory to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants