Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: dataKey Property not relevant for expanding rows #3718

Closed
simeon-s1 opened this issue Mar 9, 2023 · 4 comments
Closed

DataTable: dataKey Property not relevant for expanding rows #3718

simeon-s1 opened this issue Mar 9, 2023 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@simeon-s1
Copy link

Describe the bug

Expanded rows can either be an array of row data or when dataKey is present, an object whose keys are strings referring to the identifier of the row data and values are booleans

As of now, even with a given dataKey, the expandedRows property doesn't accept an empty object or primevue/datatable/DataTableExpandedRows object.

With expandedRows given as null, the table will fill it with an array of row objects, like it should without dataKey.

Reproducer

https://codesandbox.io/s/reverent-visvesvaraya-xypq5s?file=/src/App.vue

PrimeVue version

3.24

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Chrome 111

Steps to reproduce the behavior

expand any row, check expandedRows Property

codesandbox kinda broken, maybe a refresh is required

Expected behavior

As described in linked doc

@simeon-s1 simeon-s1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 9, 2023
@RayOneKa
Copy link

RayOneKa commented Mar 15, 2023

Same thing here. Table with 10 rows works fine, but with a larger number of rows, the expansion takes about a second to expand. primevue 3.24.0

@Christoph-Wagner
Copy link
Contributor

Still an issue for 3.37.0

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 30, 2023
@elensky
Copy link

elensky commented Dec 4, 2023

Looking forward this to be fixed. Having big performance issues even with 100 rows, but it is noticeable even with 25 rows (with objects up to 20 properties). We also having worse performance in Firefox comparing to Chrome.

version - 3.42.0

@mertsincan mertsincan modified the milestones: 3.44.0, 3.45.0 Dec 14, 2023
@mertsincan
Copy link
Member

Fixed the dataKey and performance issues in #4977

@mertsincan mertsincan self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

6 participants