Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb: Home item not using item slot #3604

Closed
Ancient-Dragon opened this issue Jan 28, 2023 · 0 comments · Fixed by #3608
Closed

Breadcrumb: Home item not using item slot #3604

Ancient-Dragon opened this issue Jan 28, 2023 · 0 comments · Fixed by #3608
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Ancient-Dragon
Copy link
Contributor

Ancient-Dragon commented Jan 28, 2023

Describe the bug

The home item no longer uses the code in the slot, this was introduced as part of this pr: #3506, although this is supposed to fix a different issue. This was working for us in 3.20.x but broke when I upgraded to 3.22.3, I would assume it broke earlier than that though.

We were using this to have a custom display for the home item, so that it aligns with the other items. It feels wrong that all the items use the slot except the home item.

I've done a basic example since I can't copy our example, but as you can see the item has a margin from the icon to the text where as the home item doesn't.

Reproducer

https://codesandbox.io/s/adoring-perlman-cchc7z?file=/src/App.vue

PrimeVue version

3.22.4

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite/Vue

Browser(s)

Any

Steps to reproduce the behavior

Just open the code sandbox and look at the difference between icons.

Expected behavior

I would expect to have the breadcrumb home item use the same slot as the rest of the items

@Ancient-Dragon Ancient-Dragon added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 28, 2023
@bahadirsofuoglu bahadirsofuoglu self-assigned this Jan 28, 2023
@bahadirsofuoglu bahadirsofuoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 28, 2023
@bahadirsofuoglu bahadirsofuoglu added this to the 3.23.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants