-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inputNumber class prop type defect #1661
Comments
Thanks for the codesandbox sample. I tried your test case within a Vite project but I didn't get any error neither development nor production mode. Could you check it with the latest PrimeVue version? |
If I dont use "build": "vue-tsc --noEmit && vite build", as my build and just use "vite build" I dont get any errors. But vue-tsc applies type checking and in https://github.com/primefaces/primevue/blob/master/src/components/inputnumber/InputNumber.d.ts class is defined as a string. Hence the type checking vue-tsc provides throws an error |
Thanks for the explanation. Still didn't get the error. I have created a repo Could you check it please? What have I missed? |
Unfortunately I cant push to your repo. However I found the error. If you dont import InputNumber in main.ts and import it in the component directly the error occurs. I dont know if vue-tsc cant use typecheking if it is imported in main.ts or whats the reasonf for that. |
Thanks for your help. It's fixed for the next version. |
It seems this bug has been reintroduced again in 3.10. |
[x ] bug report => Search github for a similar issue or PR before submitting
https://codesandbox.io/s/cocky-kilby-8w93d?file=/src/App.vue
Current behavior
In InputNumber.d.ts class is defined as a string
Expected behavior
It should allow dynmic class binding
Please tell us about your environment:
OS: Windows,
VSCode, yarn, vite, vetur, vue-tsc
Vue version: 3.05
PrimeVue version: 3.7.1
The text was updated successfully, but these errors were encountered: