Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelMenu subItems 'to' route configuration breaks menu rendering #1536

Closed
arjendekivet opened this issue Sep 10, 2021 · 6 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Milestone

Comments

@arjendekivet
Copy link

arjendekivet commented Sep 10, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

Current behavior
When configuring a 'to' on a menu subitem, the menu breaks

Expected behavior
Menu not breaking and navigating to configured 'to' route.

Minimal reproduction of the problem with instructions
** Sandbox **
https://codesandbox.io/s/priceless-orla-d6iyc?file=/src/App.vue

Please tell us about your environment:

  • Vue version: 3.2.6
  • PrimeVue version: 3.7.0

  • Browser: All

  • Suggested Fix:
    in panelmenu.js on line 124:
    "aria-expanded": isActive(item)
    should be:
    "aria-expanded": $options.isActive(item)
    Resolves the issue for me.

@mertsincan mertsincan changed the title PanelMenu subItems 'to' route configuration breaks menu rendering (simple fix provided in description) PanelMenu subItems 'to' route configuration breaks menu rendering Sep 14, 2021
@mertsincan mertsincan self-assigned this Sep 14, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 14, 2021
@mertsincan mertsincan added this to the 3.7.2 milestone Sep 14, 2021
@mertsincan
Copy link
Member

Hi,

Thanks a lot for your suggestion! Fixed now!

Best Regards,

@randybrutal
Copy link

same bug is still in 2.8.0

@tugcekucukoglu
Copy link
Member

This fix for PrimeVue 3 but it will be ported for v2.

Thanks,

@randybrutal
Copy link

I create a pull request 10 minutes ago.
Hope you team merge soon
Thanks!

@tugcekucukoglu
Copy link
Member

Could create a different issue? So we could not miss anything.

Thanks!

@randybrutal
Copy link

randybrutal commented Jan 14, 2022

Create a new issue already!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Projects
None yet
Development

No branches or pull requests

4 participants