Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panelClass to overlay components #1083

Closed
maherma-adg opened this issue Mar 13, 2021 · 4 comments
Closed

Add panelClass to overlay components #1083

maherma-adg opened this issue Mar 13, 2021 · 4 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@maherma-adg
Copy link

With the use of Teleport in Dropdown and MultiSelect components, any personalization based in scope is lost because panel is translated to body root, outside the scoped component.

Solution proposed is to add a "panelClass" property in the same way as Calendar component.

a PR can be provided if this solutions is accepted

Regards,
Manuel

@maherma-adg
Copy link
Author

Found this (#1028 (comment)) that look the same problem

@afonic
Copy link

afonic commented Mar 17, 2021

I think adding panelClass like @maherma-adg suggested is not going to solve all issues regarding when you need the
component to attach to a certain element. Adding a prop to disable it would solve this.

Besides, losing stying sometimes an Autocomplete component can be inside a dynamic component (like a search Dropdown) and closing that component flashes the dropdown in the top left corner for a few ms.

@LadislavBohm
Copy link

This is also issue for all dialogs now.

@cagataycivici cagataycivici self-assigned this Apr 14, 2021
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Apr 14, 2021
@cagataycivici cagataycivici added this to the 3.4.0 milestone Apr 14, 2021
@cagataycivici
Copy link
Member

cagataycivici commented Apr 15, 2021

I've added panel class where necessary, dialogs have class already. Note that original issue is not caused by PrimeVue, we're just using Teleport API, CSS scoping and moving the element to body is done by Vue.

@cagataycivici cagataycivici changed the title Vue3: Style lost on Dropdown & Multiselect components Add panelClass to overlay components Apr 15, 2021
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants