Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal prop to Sidebar #639

Closed
keul opened this issue Nov 12, 2018 · 0 comments
Closed

Add modal prop to Sidebar #639

keul opened this issue Nov 12, 2018 · 0 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@keul
Copy link
Contributor

keul commented Nov 12, 2018

I'm submitting a ... (check one with "x")

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior

Loosely related to #377.

Although is now possible to freely click outside the Sidebar by providing the dismissable property, the sidebar still act as a modal, so the rest of the page is not interactive.

Sometimes can be helpful to have the sidebar open but still being able to access/use the test of the page.

Expected behavior

Being able to provide something like a asModal={false} property that do not render the p-component-overlay p-sidebar-mask overlay at all.

  • PrimeReact version:
    2.0.0-rc-1
@keul keul changed the title Way to remote the modal behavior of the sidebar Way to remove the modal behavior of the Sidebar Nov 12, 2018
@cagataycivici cagataycivici changed the title Way to remove the modal behavior of the Sidebar Add modal prop to Sidebar Dec 4, 2018
@cagataycivici cagataycivici self-assigned this Dec 4, 2018
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Dec 4, 2018
@cagataycivici cagataycivici added this to the 2.0.0 milestone Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

2 participants