Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber: does not work with czech and slovak keyboard layout #6237

Closed
rrandiak opened this issue Mar 27, 2024 · 6 comments · Fixed by #6258
Closed

InputNumber: does not work with czech and slovak keyboard layout #6237

rrandiak opened this issue Mar 27, 2024 · 6 comments · Fixed by #6258
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@rrandiak
Copy link

rrandiak commented Mar 27, 2024

Describe the bug

In versions 10.5.2 and 10.5.3, InputNumber component does not accept numbers typed using slovak or czech keyboard layouts. I suspects that it is related to the fact that with sk/cz layouts, you type numbers using Shift + key. Probably could be replicated using other layouts, that types numbers in such manner. In version 10.5.1 and previous versions it works just fine.

Reproducer

https://stackblitz.com/edit/vitejs-vite-ytc4bt?file=package.json

PrimeReact version

10.5.2, 10.5.3

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

Firefox, Vivaldi, Safari

Steps to reproduce the behavior

  1. Use one of keyboard layouts (czech, slovak) to type numbers into InputNumber.

Expected behavior

No response

@rrandiak rrandiak added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 27, 2024
@melloware
Copy link
Member

Can you do me a favor and go here: https://w3c.github.io/uievents/tools/key-event-viewer.html

And use a keyboard combination to produce a (czech, slovak) number? I want to see exactly what keys you are using.

Here us USA pressing "5".

image

@rrandiak
Copy link
Author

Sure. For both layouts (czech and slovak), typing number 5 results in events:
screenshot_5_typed_using_slovak_or_czech_layout

For other numbers it's similar:

  1. hold Shift key
  2. press same key as you would press on US layout
  3. release Shift

@melloware
Copy link
Member

OK its related to this fix: #6158

I will have to figure out a way to handle this as SHIFT basically ignores the input now where before SHIFT was ignored on KeyDown but the on Keypress would accept your key.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 27, 2024
@melloware melloware added this to the 10.6.1 milestone Mar 29, 2024
@melloware melloware self-assigned this Mar 29, 2024
@melloware
Copy link
Member

@r2it-git can you try 10.6.3 and report back please?

@rrandiak
Copy link
Author

rrandiak commented Apr 9, 2024

@melloware yep, in version 10.6.3, it is working again. Thanks!

@melloware
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants