Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable checked all rows does not honor ShowSelectionElement #2251

Closed
sdt-jchau opened this issue Aug 24, 2021 · 0 comments
Closed

DataTable checked all rows does not honor ShowSelectionElement #2251

sdt-jchau opened this issue Aug 24, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@sdt-jchau
Copy link

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/bold-fast-gdhs7

Current behavior
When using ShowSelectionElement to disable checkbox selection per row, the Select All toggle selects all rows regardless of ShowSelectionElement function

Expected behavior
Select All only select rows where there's a checkbox element for selection

Minimal reproduction of the problem with instructions
https://codesandbox.io/s/bold-fast-gdhs7

  1. Click Select All checkbox at header of grid
  2. All rows are selected but only the rows where there's a checkbox should be selected

Please tell us about your environment:
Windows 10

  • React version:
    Latest

  • PrimeReact version:
    v6.5

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Chrome, Edge

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

@mertsincan mertsincan self-assigned this Nov 6, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Nov 6, 2021
@mertsincan mertsincan added this to the 7.0.0.Final milestone Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants