Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: pressing escape in a nested dialog closes the parent dialog #2241

Closed
VsevolodGolovanov opened this issue Aug 12, 2021 · 0 comments
Closed
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@VsevolodGolovanov
Copy link

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/primereact-dialog-pressing-escape-in-a-nested-dialog-closes-parent-dialog-2gh4t

Current behavior
Pressing escape in a nested dialog with closeOnEscape={false} closes the parent dialog instead.

Expected behavior
Nothing should happen. The escape press wasn't meant for the parent dialog.

Minimal reproduction of the problem with instructions
Open the linked codesandbox.
Click "Show".
Click "Show nested".
Press Escape.
Observe the first dialog closing.

Please tell us about your environment:

  • React version:
  • PrimeReact version:
    6.5.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Firefox 90.0.2

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

@mertsincan mertsincan self-assigned this Nov 7, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Nov 7, 2021
@mertsincan mertsincan added this to the 7.0.0.Final milestone Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants