Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'classnames' dependency from PrimeReact components #1653

Closed
1 task done
klovack opened this issue Oct 29, 2020 · 0 comments
Closed
1 task done

Remove 'classnames' dependency from PrimeReact components #1653

klovack opened this issue Oct 29, 2020 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@klovack
Copy link

klovack commented Oct 29, 2020

I'm submitting a ...

  • Bug report

Current behavior

I know that classnames is already added as dev dependency. But in brand new create-react-app project,
when i try to use the components from primereact, it crashed immediately.

The reason for that is missing classnames module: Below i pasted the error

Module not found: Can't resolve 'classnames' in '<Path to Project>/node_modules/primereact/components/button'

Expected behavior

I expect that i should not have to add classnames to MY project's dependency and can use primereact right away.

Please tell us about your environment:

Manjaro Linux 5.4.72-1
DE Gnome
VSCode
yarn

  • React version:

17.0.1

  • PrimeReact version:

5.0.1

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript
@mertsincan mertsincan self-assigned this Oct 30, 2020
@mertsincan mertsincan added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Oct 30, 2020
@mertsincan mertsincan changed the title missing classnames in node_modules resulting in crash Remove classnames dependency from PrimeReact components Nov 26, 2020
@mertsincan mertsincan changed the title Remove classnames dependency from PrimeReact components Remove 'classnames' dependency from PrimeReact components Nov 26, 2020
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Discussion Issue or pull request needs to be discussed by Core Team labels Nov 26, 2020
@mertsincan mertsincan added this to the 5.0.2 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants