Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Growl doesn't call onClear method #112

Closed
rinderschwein opened this issue Sep 22, 2017 · 1 comment
Closed

Growl doesn't call onClear method #112

rinderschwein opened this issue Sep 22, 2017 · 1 comment
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@rinderschwein
Copy link

rinderschwein commented Sep 22, 2017

Hi,

Growl doesn't call the onClear method because the onClick eventhandler of the close button calls the remove function.

<div className="ui-growl-icon-close fa fa-close" onClick={(event) => this.remove(event, msg, index)}></div>

Seems that Messages does it right.

var closeIcon = <a href="#" className="ui-messages-close" onClick={this.clear}>

Is this a known issue? I can't find anything about it in the documentation or in the github issues.

@cagataycivici cagataycivici added this to the 1.0.2 milestone Oct 9, 2017
@cagataycivici cagataycivici self-assigned this Oct 9, 2017
@cagataycivici cagataycivici added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a defect related to a specific component. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 9, 2017
@cagataycivici
Copy link
Member

Aligned with PrimeNG now, instead use onClose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants