Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubar: submenu's border radius style using wrong token name #17612

Open
1 of 4 tasks
zeatan opened this issue Feb 7, 2025 · 0 comments
Open
1 of 4 tasks

Menubar: submenu's border radius style using wrong token name #17612

zeatan opened this issue Feb 7, 2025 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@zeatan
Copy link

zeatan commented Feb 7, 2025

Describe the bug

In p-menubar-submenu class, borde-radius using menubar.border.radius.

border-radius: ${dt('menubar.border.radius')};

Correct token may menubar.submenu.border.radius.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-wf8jsdkh?file=src%2Fapp%2Fapp.config.ts

Environment

macbook pro os:12.7.6

Angular version

v19

PrimeNG version

v19

Node version

18.20

Browser(s)

Chrome 132

Steps to reproduce the behavior

  1. craete Menubar and set items.
  2. customize root borer radius to 0 and submenu border radius to 12px.
  3. click root item to display submenu.
  4. submenu's radius is 0 (expected as 12px).

Expected behavior

According to Menubar Theming dcoument,  p-menubar-submenu class should below.

border-radius: ${dt('menubar.submenu.border.radius')};
@zeatan zeatan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant