Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabList: Tabindex of Navigation Buttons (Next/Previous) not set #17270

Closed
4 tasks
jase88 opened this issue Jan 1, 2025 · 0 comments · Fixed by #17269
Closed
4 tasks

TabList: Tabindex of Navigation Buttons (Next/Previous) not set #17270

jase88 opened this issue Jan 1, 2025 · 0 comments · Fixed by #17269
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.6

Comments

@jase88
Copy link
Contributor

jase88 commented Jan 1, 2025

Describe the bug

The attribute tabindex is not set on both navigation buttons (next and previous) on TabList

Pull Request Link

#17269

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/orpkxraq-wspx721e?file=src%2Fapp%2Ftabs-controlled-demo.html

Environment

MacOS

Angular version

19.0.5

PrimeNG version

v19

Node version

22.12.0

Browser(s)

Chrome

Steps to reproduce the behavior

  1. See provided stackblitz
  2. Look at the attribute tabindex of the DOM node for the next button (plus sign), which says tabindex="[Computed: 1]"

Expected behavior

The tabindex should be just 1
@jase88 jase88 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 1, 2025
@jase88 jase88 mentioned this issue Jan 1, 2025
Merged
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 15, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 15, 2025
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.6
Development

Successfully merging a pull request may close this issue.

fix(tablist): tabindex now correctly set from unwrapped computed signal jase88/primeng
2 participants
@jase88 @mertsincan