Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-table/Aura: Dark Mode header for Frozen + Sorted Column is transparent #16940

Closed
allout58 opened this issue Dec 4, 2024 · 1 comment
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@allout58
Copy link

allout58 commented Dec 4, 2024

Describe the bug

When using the Aura theme in Dark Mode (not Light Mode), a frozen column, when sorted, has a translucent background for it's header and as such allows the column headers to the right to completely clobber the text of the header.

Bad (some clipping):
image
Worst case (completely unreadable):
image

Environment

N/A

Reproducer

https://stackblitz.com/edit/github-gnsykl (reused from #16939)

Angular version

18.2.12

PrimeNG version

18.0.0-rc2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.17.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Build out a table with a sortable and frozen column
  2. Sort the frozen column
  3. Scroll to the right to see the non-frozen column header visible behind the frozen+sorted column header

Expected behavior

Frozen columns should still be completely usable even when sorted in Dark Mode

@allout58 allout58 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 4, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 11, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 11, 2024
@mehmetcetin01140 mehmetcetin01140 modified the milestones: 18.0.1, 19.0.1 Dec 17, 2024
@mertsincan mertsincan modified the milestones: 19.0.1, 19.0.2 Dec 19, 2024
@cetincakiroglu
Copy link
Contributor

fixed in 516e7e9

@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 23, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

4 participants