Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiselect: aria attributes should not be set on <li> elements #14946

Closed
markuczy opened this issue Mar 5, 2024 · 1 comment · Fixed by #15153
Closed

Multiselect: aria attributes should not be set on <li> elements #14946

markuczy opened this issue Mar 5, 2024 · 1 comment · Fixed by #15153
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
17.13.0

Comments

@markuczy
Copy link

markuczy commented Mar 5, 2024

Describe the bug

  • elements for each multiselect item should not have the following properties set: - aria-label - aria-setsize - aria-posinset - aria-selected

    Screenshot of the accessibility checker report taken from the documentation(https://primeng.org/multiselect):
    image

    Environment

    Ubuntu 22.04, WSL 2, Windows 11 PRO

    Reproducer

    No response

    Angular version

    15.2.10

    PrimeNG version

    17.9.0

    Build / Runtime

    Angular CLI App

    Language

    TypeScript

    Node version (for AoT issues node --version)

    18.18.0

    Browser(s)

    No response

    Steps to reproduce the behavior

    No response

    Expected behavior

    Expected Multiselect component to not raise any accessibility issues.

    		•
    @markuczy markuczy added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 5, 2024
    @vinodneppalli62
    Copy link

    Each li tag is missing role='option' which is why probably aria checker is complaining.

    @mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
    @TaneliTuomola TaneliTuomola mentioned this issue Mar 25, 2024
    Merged
    @cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 29, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    Component: Accessibility Issue or pull request is related to WCAG or ARIA
    Projects
    None yet
    Milestone
    17.13.0
    Development

    Successfully merging a pull request may close this issue.

    fix #14958 MultiSelectItem role=option TaneliTuomola/primeng
    4 participants
    @vinodneppalli62 @cetincakiroglu @mehmetcetin01140 @markuczy