-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wip] 공통 컴포넌트 제작(6) PostListItem, TextIconButton(수정) #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loevray
changed the title
[Wip] 공통 컴포넌트 제작(6) PostListItem
[Wip] 공통 컴포넌트 제작(6) PostListItem, TextIconButton(수정)
Jan 2, 2024
whdgur5717
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
- props 네이밍은 딱히 이해 안가는 부분이 없었던 것 같습니다!
- 제안해주신 전달방법은 굉장히 좋은 것 같습니다. 다같이 도입해보면 코드가 한층 깔끔해질 것 같습니다
JaeHyunGround
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 !!
props 전달 방법도 좋은 것 같아요 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 사항
관련 이슈
#7 6번째 태스크입니다
PR Point
컴포넌트 props의 덩치가 너무 커지는건 아닌가 고민됩니다ㅎㅎ
참고사항
재사용 가능하게 만든다는 것이 참으로 어려운 것 같습니다! 이번에 TextIconButton도 꽤 수정사항이 생겨서 같이 봐주시면 감사하겠습니다.