Avoid checking isSplittable for files smaller than the split max size#4540
Merged
electrum merged 1 commit intotrinodb:masterfrom Jul 27, 2020
Merged
Conversation
electrum
reviewed
Jul 22, 2020
presto-hive/src/main/java/io/prestosql/plugin/hive/util/InternalHiveSplitFactory.java
Outdated
Show resolved
Hide resolved
electrum
reviewed
Jul 22, 2020
presto-hive/src/main/java/io/prestosql/plugin/hive/BackgroundHiveSplitLoader.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
minimum-splittable-size
branch
2 times, most recently
from
1173622 to
385f927
Compare
For some input formats, the isSplittable check is non-trivial and can add a significant amount of time to split generation when handling a large number of very small files. This change allows files smaller than the max initial split size to avoid that check and considers them unsplittable instead.
pettyjamesm
force-pushed
the
minimum-splittable-size
branch
from
385f927 to
ad12e61
Compare
electrum
approved these changes
Jul 27, 2020
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross contribution of prestodb/presto#14877
For some input formats, the isSplittable check is non-trivial and can add a significant amount of time to split generation. This change allows files smaller than the max split size to avoid that check and simply calls them unsplittable since they're within the split target range already.