From e74a8fd45e24caa020f36aa8ce1446d7096c3cc3 Mon Sep 17 00:00:00 2001
From: Ke <ke.404notfound@gmail.com>
Date: Thu, 19 Feb 2026 01:15:23 -0800
Subject: [PATCH] feat(native): Add config for asyc cache flush threshold

---
 .../presto_cpp/main/PrestoServer.cpp               |  3 ++-
 .../presto_cpp/main/common/Configs.cpp             |  5 +++++
 .../presto_cpp/main/common/Configs.h               |  8 ++++++++
 .../presto_cpp/main/common/tests/ConfigTest.cpp    | 14 ++++++++++++++
 4 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/presto-native-execution/presto_cpp/main/PrestoServer.cpp b/presto-native-execution/presto_cpp/main/PrestoServer.cpp
index fce198fec93c9..4385126c1fa96 100644
--- a/presto-native-execution/presto_cpp/main/PrestoServer.cpp
+++ b/presto-native-execution/presto_cpp/main/PrestoServer.cpp
@@ -1079,7 +1079,8 @@ void PrestoServer::initializeVeloxMemory() {
         systemConfig->asyncCacheMaxSsdWriteRatio(),
         systemConfig->asyncCacheSsdSavableRatio(),
         systemConfig->asyncCacheMinSsdSavableBytes(),
-        systemConfig->asyncCacheNumShards()};
+        systemConfig->asyncCacheNumShards(),
+        systemConfig->asyncCacheSsdFlushThresholdBytes()};
     cache_ = velox::cache::AsyncDataCache::create(
         velox::memory::memoryManager()->allocator(),
         std::move(ssd),
diff --git a/presto-native-execution/presto_cpp/main/common/Configs.cpp b/presto-native-execution/presto_cpp/main/common/Configs.cpp
index 0cd35c7e4816b..2a7ed7a838f05 100644
--- a/presto-native-execution/presto_cpp/main/common/Configs.cpp
+++ b/presto-native-execution/presto_cpp/main/common/Configs.cpp
@@ -210,6 +210,7 @@ SystemConfig::SystemConfig() {
           NUM_PROP(kAsyncCacheSsdSavableRatio, 0.125),
           NUM_PROP(kAsyncCacheMinSsdSavableBytes, 1 << 24 /*16MB*/),
           NUM_PROP(kAsyncCacheNumShards, 4),
+          NUM_PROP(kAsyncCacheSsdFlushThresholdBytes, 0),
           STR_PROP(kAsyncCachePersistenceInterval, "0s"),
           BOOL_PROP(kAsyncCacheSsdDisableFileCow, false),
           BOOL_PROP(kSsdCacheChecksumEnabled, false),
@@ -719,6 +720,10 @@ int32_t SystemConfig::asyncCacheNumShards() const {
   return optionalProperty<int32_t>(kAsyncCacheNumShards).value();
 }
 
+uint64_t SystemConfig::asyncCacheSsdFlushThresholdBytes() const {
+  return optionalProperty<uint64_t>(kAsyncCacheSsdFlushThresholdBytes).value();
+}
+
 std::chrono::duration<double> SystemConfig::asyncCachePersistenceInterval()
     const {
   return velox::config::toDuration(
diff --git a/presto-native-execution/presto_cpp/main/common/Configs.h b/presto-native-execution/presto_cpp/main/common/Configs.h
index dc20f46609654..aa4d50f226e70 100644
--- a/presto-native-execution/presto_cpp/main/common/Configs.h
+++ b/presto-native-execution/presto_cpp/main/common/Configs.h
@@ -438,6 +438,12 @@ class SystemConfig : public ConfigBase {
   static constexpr std::string_view kAsyncCacheNumShards{
       "async-cache-num-shards"};
 
+  /// The maximum threshold in bytes for triggering SSD flush. When the
+  /// accumulated SSD-savable bytes exceed this value, a flush to SSD is
+  /// triggered. Set to 0 to disable this threshold (default).
+  static constexpr std::string_view kAsyncCacheSsdFlushThresholdBytes{
+      "async-cache-ssd-flush-threshold-bytes"};
+
   /// The interval for persisting in-memory cache to SSD. Setting this config
   /// to a non-zero value will activate periodic cache persistence.
   static constexpr std::string_view kAsyncCachePersistenceInterval{
@@ -1079,6 +1085,8 @@ class SystemConfig : public ConfigBase {
 
   int32_t asyncCacheNumShards() const;
 
+  uint64_t asyncCacheSsdFlushThresholdBytes() const;
+
   std::chrono::duration<double> asyncCachePersistenceInterval() const;
 
   bool asyncCacheSsdDisableFileCow() const;
diff --git a/presto-native-execution/presto_cpp/main/common/tests/ConfigTest.cpp b/presto-native-execution/presto_cpp/main/common/tests/ConfigTest.cpp
index 694ce3d14b251..8eca5a8de78ff 100644
--- a/presto-native-execution/presto_cpp/main/common/tests/ConfigTest.cpp
+++ b/presto-native-execution/presto_cpp/main/common/tests/ConfigTest.cpp
@@ -241,6 +241,20 @@ TEST_F(ConfigTest, asyncCacheNumShards) {
   ASSERT_EQ(config.asyncCacheNumShards(), 8);
 }
 
+TEST_F(ConfigTest, asyncCacheSsdFlushThresholdBytes) {
+  SystemConfig config;
+  init(config, {});
+  // Test default value is 0
+  ASSERT_EQ(config.asyncCacheSsdFlushThresholdBytes(), 0);
+
+  // Test custom value
+  init(
+      config,
+      {{std::string(SystemConfig::kAsyncCacheSsdFlushThresholdBytes),
+        "134217728"}});
+  ASSERT_EQ(config.asyncCacheSsdFlushThresholdBytes(), 134217728);
+}
+
 TEST_F(ConfigTest, remoteFunctionServer) {
   SystemConfig config;
   init(config, {});