From a8bcbe1b0c93d66cabc862a6e57bdd4b68915f36 Mon Sep 17 00:00:00 2001
From: Kewen Wang <kewen@meta.com>
Date: Mon, 1 Dec 2025 11:52:27 -0800
Subject: [PATCH] Support Spark2 and Spark3 by subdirs in module
 presto-spark-classloader-interface

Delete two modules presto-spark-classloader-spark2 and presto-spark-classloader-spark3 in the previous approach to support both Spark2 and Spark3. Move the previous implementations into subdirs into existing module presto-spark-classloader-interface. Clean up dependencies in pom files of root, presto-spark-base and presto-spark-launcher.
---
 pom.xml                                       | 147 +-----------------
 presto-spark-base/pom.xml                     |  35 ++---
 presto-spark-classloader-interface/pom.xml    |  99 ++++++++++--
 .../MutablePartitionId.java                   |   0
 .../MutablePartitionIdOrdering.java           |   0
 ...stoSparkNativeExecutionShuffleManager.java |   0
 .../PrestoSparkUtils.java                     |   0
 .../classloader_interface/ScalaUtils.java     |   0
 .../MutablePartitionId.java                   |   0
 .../MutablePartitionIdOrdering.java           |   0
 ...stoSparkNativeExecutionShuffleManager.java |   0
 .../PrestoSparkUtils.java                     |   0
 .../classloader_interface/ScalaUtils.java     |   0
 presto-spark-classloader-spark2/pom.xml       |  32 ----
 presto-spark-classloader-spark3/pom.xml       |  39 -----
 presto-spark-launcher/pom.xml                 |  72 +++++----
 16 files changed, 142 insertions(+), 282 deletions(-)
 rename {presto-spark-classloader-spark2/src/main/java => presto-spark-classloader-interface/src/main/java-spark2}/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java (100%)
 rename {presto-spark-classloader-spark2/src/main/java => presto-spark-classloader-interface/src/main/java-spark2}/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java (100%)
 rename {presto-spark-classloader-spark2/src/main/java => presto-spark-classloader-interface/src/main/java-spark2}/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java (100%)
 rename {presto-spark-classloader-spark2/src/main/java => presto-spark-classloader-interface/src/main/java-spark2}/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java (100%)
 rename {presto-spark-classloader-spark2/src/main/java => presto-spark-classloader-interface/src/main/java-spark2}/com/facebook/presto/spark/classloader_interface/ScalaUtils.java (100%)
 rename {presto-spark-classloader-spark3/src/main/java => presto-spark-classloader-interface/src/main/java-spark3}/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java (100%)
 rename {presto-spark-classloader-spark3/src/main/java => presto-spark-classloader-interface/src/main/java-spark3}/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java (100%)
 rename {presto-spark-classloader-spark3/src/main/java => presto-spark-classloader-interface/src/main/java-spark3}/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java (100%)
 rename {presto-spark-classloader-spark3/src/main/java => presto-spark-classloader-interface/src/main/java-spark3}/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java (100%)
 rename {presto-spark-classloader-spark3/src/main/java => presto-spark-classloader-interface/src/main/java-spark3}/com/facebook/presto/spark/classloader_interface/ScalaUtils.java (100%)
 delete mode 100644 presto-spark-classloader-spark2/pom.xml
 delete mode 100644 presto-spark-classloader-spark3/pom.xml

diff --git a/pom.xml b/pom.xml
index 84545e0df8373..2d896617e0254 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2844,6 +2844,7 @@
                         </dependency>
                     </dependencies>
                     <configuration>
+                        <skip>true</skip>
                         <rules>
                             <requireUpperBoundDeps>
                                 <excludes combine.children="append">
@@ -2863,6 +2864,7 @@
                     <groupId>org.basepom.maven</groupId>
                     <artifactId>duplicate-finder-maven-plugin</artifactId>
                     <configuration>
+                        <skip>true</skip>
                         <ignoredClassPatterns combine.children="append">
                             <ignoredClassPattern>com.github.benmanes.caffeine.*</ignoredClassPattern>
                             <!-- Duplicate class is being brought in by commons-io & log4j-api -->
@@ -2982,6 +2984,7 @@
                     </execution>
                 </executions>
             </plugin>
+
         </plugins>
     </build>
 
@@ -3223,149 +3226,5 @@
                 </plugins>
             </build>
         </profile>
-        <profile>
-            <id>spark2</id>
-
-            <activation>
-                <activeByDefault>true</activeByDefault>
-                <property>
-                    <name>!spark-version</name>
-                </property>
-            </activation>
-
-            <properties>
-                <dep.spark.version>2.0.2-6</dep.spark.version>
-            </properties>
-
-            <modules>
-                <module>presto-spark-classloader-spark2</module>
-            </modules>
-
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <groupId>org.apache.maven.plugins</groupId>
-                            <artifactId>maven-enforcer-plugin</artifactId>
-                            <version>3.3.0</version>
-                            <dependencies>
-                                <dependency>
-                                    <groupId>org.codehaus.mojo</groupId>
-                                    <artifactId>extra-enforcer-rules</artifactId>
-                                    <version>1.11.0</version>
-                                </dependency>
-                            </dependencies>
-                            <configuration>
-                                <skip>true</skip>
-                                <rules>
-                                    <requireUpperBoundDeps>
-                                        <excludes combine.children="append">
-                                            <!-- TODO: fix this in Airlift resolver -->
-                                            <exclude>org.codehaus.plexus:plexus-utils</exclude>
-                                            <exclude>com.google.guava:guava</exclude>
-                                            <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
-                                            <exclude>com.fasterxml.jackson.core:jackson-core</exclude>
-                                            <exclude>com.fasterxml.jackson.core:jackson-databind</exclude>
-                                        </excludes>
-                                    </requireUpperBoundDeps>
-                                </rules>
-                            </configuration>
-                        </plugin>
-
-                        <plugin>
-                            <groupId>org.basepom.maven</groupId>
-                            <artifactId>duplicate-finder-maven-plugin</artifactId>
-                            <configuration>
-                                <skip>true</skip>
-                                <ignoredClassPatterns combine.children="append">
-                                    <ignoredClassPattern>com.github.benmanes.caffeine.*</ignoredClassPattern>
-                                    <!-- Duplicate class is being brought in by commons-io & log4j-api -->
-                                    <ignoredClassPattern>META-INF.versions.9.module-info</ignoredClassPattern>
-                                    <!-- Duplicate class is being brought in by several netty dependencies-->
-                                    <ignoredClassPattern>META-INF.versions.11.module-info</ignoredClassPattern>
-                                    <!-- Ignore duplicate classes related to lucene-core and ranger-apache -->
-                                    <ignoredClassPattern>META-INF.versions.9.org.apache.lucene.*</ignoredClassPattern>
-                                </ignoredClassPatterns>
-
-                            </configuration>
-                        </plugin>
-
-                    </plugins>
-                </pluginManagement>
-            </build>
-
-        </profile>
-        <profile>
-            <id>spark3</id>
-
-            <activation>
-                <property>
-                    <name>spark-version</name>
-                    <value>3</value>
-                </property>
-            </activation>
-
-            <properties>
-                <dep.spark.version>3.4.1-1</dep.spark.version>
-            </properties>
-
-            <modules>
-                <module>presto-spark-classloader-spark3</module>
-            </modules>
-
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <groupId>org.apache.maven.plugins</groupId>
-                            <artifactId>maven-enforcer-plugin</artifactId>
-                            <version>3.3.0</version>
-                            <dependencies>
-                                <dependency>
-                                    <groupId>org.codehaus.mojo</groupId>
-                                    <artifactId>extra-enforcer-rules</artifactId>
-                                    <version>1.11.0</version>
-                                </dependency>
-                            </dependencies>
-                            <configuration>
-                                <skip>true</skip>
-                                <rules>
-                                    <requireUpperBoundDeps>
-                                        <excludes combine.children="append">
-                                            <!-- TODO: fix this in Airlift resolver -->
-                                            <exclude>org.codehaus.plexus:plexus-utils</exclude>
-                                            <exclude>com.google.guava:guava</exclude>
-                                            <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
-                                            <exclude>com.fasterxml.jackson.core:jackson-core</exclude>
-                                            <exclude>com.fasterxml.jackson.core:jackson-databind</exclude>
-                                        </excludes>
-                                    </requireUpperBoundDeps>
-                                </rules>
-                            </configuration>
-                        </plugin>
-
-                        <plugin>
-                            <groupId>org.basepom.maven</groupId>
-                            <artifactId>duplicate-finder-maven-plugin</artifactId>
-                            <configuration>
-                                <skip>true</skip>
-                                <ignoredClassPatterns combine.children="append">
-                                    <ignoredClassPattern>com.github.benmanes.caffeine.*</ignoredClassPattern>
-                                    <!-- Duplicate class is being brought in by commons-io & log4j-api -->
-                                    <ignoredClassPattern>META-INF.versions.9.module-info</ignoredClassPattern>
-                                    <!-- Duplicate class is being brought in by several netty dependencies-->
-                                    <ignoredClassPattern>META-INF.versions.11.module-info</ignoredClassPattern>
-                                    <!-- Ignore duplicate classes related to lucene-core and ranger-apache -->
-                                    <ignoredClassPattern>META-INF.versions.9.org.apache.lucene.*</ignoredClassPattern>
-                                </ignoredClassPatterns>
-
-                            </configuration>
-                        </plugin>
-
-                    </plugins>
-                </pluginManagement>
-            </build>
-
-        </profile>
     </profiles>
 </project>
diff --git a/presto-spark-base/pom.xml b/presto-spark-base/pom.xml
index b4fd0b206c38e..d5f390ca35986 100644
--- a/presto-spark-base/pom.xml
+++ b/presto-spark-base/pom.xml
@@ -467,6 +467,12 @@
                         <ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency>
                         <ignoredUnusedDeclaredDependency>org.apache.httpcomponents:httpcore</ignoredUnusedDeclaredDependency>
                     </ignoredUnusedDeclaredDependencies>
+                    <ignoredDependencies>
+                        <ignoredDependency>org.glassfish.hk2.external:jakarta.inject</ignoredDependency>
+                        <ignoredDependency>org.apache.hadoop:hadoop-client-api</ignoredDependency>
+                        <ignoredDependency>jakarta.annotation:jakarta.annotation-api</ignoredDependency>
+                        <ignoredDependency>jakarta.validation:jakarta.validation-api</ignoredDependency>
+                    </ignoredDependencies>
                 </configuration>
             </plugin>
         </plugins>
@@ -540,14 +546,6 @@
                     <name>!spark-version</name>
                 </property>
             </activation>
-
-            <dependencies>
-                <dependency>
-                    <groupId>com.facebook.presto</groupId>
-                    <artifactId>presto-spark-classloader-spark2</artifactId>
-                    <version>${project.version}</version>
-                </dependency>
-            </dependencies>
         </profile>
 
         <profile>
@@ -560,12 +558,11 @@
                 </property>
             </activation>
 
+            <properties>
+                <spark.version.main>3</spark.version.main>
+            </properties>
+
             <dependencies>
-                <dependency>
-                    <groupId>com.facebook.presto</groupId>
-                    <artifactId>presto-spark-classloader-spark3</artifactId>
-                    <version>${project.version}</version>
-                </dependency>
 
                 <dependency>
                     <groupId>com.facebook.presto.spark</groupId>
@@ -614,18 +611,6 @@
 
             <build>
                 <plugins>
-                    <plugin>
-                        <groupId>org.apache.maven.plugins</groupId>
-                        <artifactId>maven-dependency-plugin</artifactId>
-                        <configuration>
-                            <ignoredDependencies>
-                                <ignoredDependency>org.glassfish.hk2.external:jakarta.inject</ignoredDependency>
-                                <ignoredDependency>org.apache.hadoop:hadoop-client-api</ignoredDependency>
-                                <ignoredDependency>jakarta.annotation:jakarta.annotation-api</ignoredDependency>
-                                <ignoredDependency>jakarta.validation:jakarta.validation-api</ignoredDependency>
-                            </ignoredDependencies>
-                        </configuration>
-                    </plugin>
 
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
diff --git a/presto-spark-classloader-interface/pom.xml b/presto-spark-classloader-interface/pom.xml
index 8ff7dd7d2e464..097ff6f25194d 100644
--- a/presto-spark-classloader-interface/pom.xml
+++ b/presto-spark-classloader-interface/pom.xml
@@ -13,6 +13,7 @@
     <properties>
         <air.main.basedir>${project.parent.basedir}</air.main.basedir>
         <air.check.skip-modernizer>true</air.check.skip-modernizer>
+        <spark.version.main>2</spark.version.main>
     </properties>
 
     <dependencies>
@@ -33,6 +34,81 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <outputDirectory>target/java-spark${spark.version.main}/classes</outputDirectory>
+        <testOutputDirectory>target/java-spark${spark.version.main}/test-classes</testOutputDirectory>
+        <pluginManagement>
+            <plugins>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-enforcer-plugin</artifactId>
+                    <version>3.3.0</version>
+                    <dependencies>
+                        <dependency>
+                            <groupId>org.codehaus.mojo</groupId>
+                            <artifactId>extra-enforcer-rules</artifactId>
+                            <version>1.6.2</version>
+                        </dependency>
+                    </dependencies>
+                    <configuration>
+                        <skip>true</skip>
+                        <rules>
+                            <requireUpperBoundDeps>
+                                <excludes combine.children="append">
+                                    <!-- TODO: fix this in Airlift resolver -->
+                                    <exclude>org.codehaus.plexus:plexus-utils</exclude>
+                                    <exclude>com.google.guava:guava</exclude>
+                                    <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
+                                    <exclude>com.fasterxml.jackson.core:jackson-core</exclude>
+                                    <exclude>com.fasterxml.jackson.core:jackson-databind</exclude>
+                                </excludes>
+                            </requireUpperBoundDeps>
+                        </rules>
+                    </configuration>
+                </plugin>
+
+                <plugin>
+                    <groupId>org.basepom.maven</groupId>
+                    <artifactId>duplicate-finder-maven-plugin</artifactId>
+                    <configuration>
+                        <skip>true</skip>
+                        <ignoredClassPatterns combine.children="append">
+                            <ignoredClassPattern>com.github.benmanes.caffeine.*</ignoredClassPattern>
+                            <!-- Duplicate class is being brought in by commons-io & log4j-api -->
+                            <ignoredClassPattern>META-INF.versions.9.module-info</ignoredClassPattern>
+                            <!-- Duplicate class is being brought in by several netty dependencies-->
+                            <ignoredClassPattern>META-INF.versions.11.module-info</ignoredClassPattern>
+                            <!-- Ignore duplicate classes related to lucene-core and ranger-apache -->
+                            <ignoredClassPattern>META-INF.versions.9.org.apache.lucene.*</ignoredClassPattern>
+                        </ignoredClassPatterns>
+
+                    </configuration>
+                </plugin>
+
+            </plugins>
+        </pluginManagement>
+        <plugins>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>build-helper-maven-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>add-sources</id>
+                        <phase>generate-sources</phase>
+                        <goals>
+                            <goal>add-source</goal>
+                        </goals>
+                        <configuration>
+                            <sources>
+                                <source>src/main/java-spark${spark.version.main}</source>
+                            </sources>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
+
     <profiles>
         <profile>
             <id>spark2</id>
@@ -44,15 +120,12 @@
                 </property>
             </activation>
 
-            <dependencies>
-                <dependency>
-                    <groupId>com.facebook.presto</groupId>
-                    <artifactId>presto-spark-classloader-spark2</artifactId>
-                    <version>${project.version}</version>
-                </dependency>
-            </dependencies>
-
+            <properties>
+                <spark.version.main>2</spark.version.main>
+                <dep.spark.version>2.0.2-6</dep.spark.version>
+            </properties>
         </profile>
+
         <profile>
             <id>spark3</id>
 
@@ -63,12 +136,12 @@
                 </property>
             </activation>
 
+            <properties>
+                <spark.version.main>3</spark.version.main>
+                <dep.spark.version>3.4.1-1</dep.spark.version>
+            </properties>
+
             <dependencies>
-                <dependency>
-                    <groupId>com.facebook.presto</groupId>
-                    <artifactId>presto-spark-classloader-spark3</artifactId>
-                    <version>${project.version}</version>
-                </dependency>
                 <dependency>
                     <groupId>org.scala-lang</groupId>
                     <artifactId>scala-library</artifactId>
diff --git a/presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java b/presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java
similarity index 100%
rename from presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java
rename to presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java
diff --git a/presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java b/presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java
similarity index 100%
rename from presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java
rename to presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java
diff --git a/presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java b/presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java
similarity index 100%
rename from presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java
rename to presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java
diff --git a/presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java b/presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java
similarity index 100%
rename from presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java
rename to presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java
diff --git a/presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/ScalaUtils.java b/presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/ScalaUtils.java
similarity index 100%
rename from presto-spark-classloader-spark2/src/main/java/com/facebook/presto/spark/classloader_interface/ScalaUtils.java
rename to presto-spark-classloader-interface/src/main/java-spark2/com/facebook/presto/spark/classloader_interface/ScalaUtils.java
diff --git a/presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java b/presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java
similarity index 100%
rename from presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java
rename to presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/MutablePartitionId.java
diff --git a/presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java b/presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java
similarity index 100%
rename from presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java
rename to presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/MutablePartitionIdOrdering.java
diff --git a/presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java b/presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java
similarity index 100%
rename from presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java
rename to presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/PrestoSparkNativeExecutionShuffleManager.java
diff --git a/presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java b/presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java
similarity index 100%
rename from presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java
rename to presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/PrestoSparkUtils.java
diff --git a/presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/ScalaUtils.java b/presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/ScalaUtils.java
similarity index 100%
rename from presto-spark-classloader-spark3/src/main/java/com/facebook/presto/spark/classloader_interface/ScalaUtils.java
rename to presto-spark-classloader-interface/src/main/java-spark3/com/facebook/presto/spark/classloader_interface/ScalaUtils.java
diff --git a/presto-spark-classloader-spark2/pom.xml b/presto-spark-classloader-spark2/pom.xml
deleted file mode 100644
index 0abd6b7178d44..0000000000000
--- a/presto-spark-classloader-spark2/pom.xml
+++ /dev/null
@@ -1,32 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-  <parent>
-    <artifactId>presto-root</artifactId>
-    <groupId>com.facebook.presto</groupId>
-    <version>0.297-SNAPSHOT</version>
-  </parent>
-  <modelVersion>4.0.0</modelVersion>
-
-  <artifactId>presto-spark-classloader-spark2</artifactId>
-  <name>presto-spark-classloader-spark2</name>
-
-  <properties>
-    <air.main.basedir>${project.parent.basedir}</air.main.basedir>
-  </properties>
-
-  <dependencies>
-
-    <dependency>
-      <groupId>com.facebook.presto.spark</groupId>
-      <artifactId>spark-core</artifactId>
-      <scope>provided</scope>
-    </dependency>
-
-    <dependency>
-      <groupId>com.google.guava</groupId>
-      <artifactId>guava</artifactId>
-    </dependency>
-
-  </dependencies>
-
-</project>
\ No newline at end of file
diff --git a/presto-spark-classloader-spark3/pom.xml b/presto-spark-classloader-spark3/pom.xml
deleted file mode 100644
index aba2bf8725868..0000000000000
--- a/presto-spark-classloader-spark3/pom.xml
+++ /dev/null
@@ -1,39 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-  <parent>
-    <artifactId>presto-root</artifactId>
-    <groupId>com.facebook.presto</groupId>
-    <version>0.296-SNAPSHOT</version>
-  </parent>
-  <modelVersion>4.0.0</modelVersion>
-
-  <artifactId>presto-spark-classloader-spark3</artifactId>
-  <name>presto-spark-classloader-spark3</name>
-
-  <properties>
-    <air.main.basedir>${project.parent.basedir}</air.main.basedir>
-  </properties>
-
-  <dependencies>
-
-    <dependency>
-      <groupId>com.google.guava</groupId>
-      <artifactId>guava</artifactId>
-    </dependency>
-
-    <dependency>
-      <groupId>com.facebook.presto.spark</groupId>
-      <artifactId>spark-core</artifactId>
-      <version>3.4.1-1</version>
-      <scope>compile</scope>
-    </dependency>
-
-    <dependency>
-      <groupId>org.scala-lang</groupId>
-      <artifactId>scala-library</artifactId>
-      <scope>provided</scope>
-    </dependency>
-
-  </dependencies>
-
-</project>
\ No newline at end of file
diff --git a/presto-spark-launcher/pom.xml b/presto-spark-launcher/pom.xml
index 0cdc2ad84bade..87c8c11f71c83 100644
--- a/presto-spark-launcher/pom.xml
+++ b/presto-spark-launcher/pom.xml
@@ -51,35 +51,6 @@
 
     </dependencies>
 
-    <profiles>
-        <profile>
-            <id>spark3</id>
-
-            <activation>
-                <property>
-                    <name>spark-version</name>
-                    <value>3</value>
-                </property>
-            </activation>
-
-            <dependencies>
-                <dependency>
-                    <groupId>com.facebook.presto.spark</groupId>
-                    <artifactId>spark-core</artifactId>
-                    <version>3.4.1-1</version>
-                    <scope>provided</scope>
-                </dependency>
-
-                <dependency>
-                    <groupId>org.scala-lang</groupId>
-                    <artifactId>scala-library</artifactId>
-                    <scope>provided</scope>
-                </dependency>
-            </dependencies>
-        </profile>
-    </profiles>
-
-
     <build>
         <plugins>
             <plugin>
@@ -139,4 +110,47 @@
         </plugins>
     </build>
 
+    <profiles>
+        <profile>
+            <id>spark2</id>
+
+            <activation>
+                <activeByDefault>true</activeByDefault>
+                <property>
+                    <name>!spark-version</name>
+                </property>
+            </activation>
+        </profile>
+
+        <profile>
+            <id>spark3</id>
+
+            <activation>
+                <property>
+                    <name>spark-version</name>
+                    <value>3</value>
+                </property>
+            </activation>
+
+            <properties>
+                <spark.version.main>3</spark.version.main>
+            </properties>
+
+            <dependencies>
+                <dependency>
+                    <groupId>com.facebook.presto.spark</groupId>
+                    <artifactId>spark-core</artifactId>
+                    <version>3.4.1-1</version>
+                    <scope>provided</scope>
+                </dependency>
+
+                <dependency>
+                    <groupId>org.scala-lang</groupId>
+                    <artifactId>scala-library</artifactId>
+                    <scope>provided</scope>
+                </dependency>
+            </dependencies>
+        </profile>
+    </profiles>
+
 </project>