Exclude executable jars when publishing maven artifacts #25900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
Joe-Abraham and
Mariamalmesfer
and removed request for
a team
tdcmeehan
approved these changes
Aug 27, 2025
Contributor
Author
|
Activate the profile |
6 tasks
unidevel
added a commit
that referenced
this pull request
Aug 27, 2025
## Description This PR update the github action to publish maven artifacts with central publishing method, since maven repo doesn't allow executable jar(with shell script) to be published, so we will create a github release and publish the jars Need fix in release branch: #25900 Sample release for executable jars https://github.com/unix280/presto/releases ## Motivation and Context ## Impact Release 0.294 ## Test Plan Tested the github release in myrepo: https://github.com/unix280/presto/actions/runs/17272968441 Tested the maven publishing in local env ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
unidevel
added a commit
to unidevel/presto
that referenced
this pull request
Aug 28, 2025
After migrated the central publishing, the executable jar(with shell script) files can not be published because of the maven repository limitation This PR exclude the jars with shell script by adding a profile `executable-jar`, and add a dummy file so that the java doc can be generated for publishing Release 0.294 Manually tested <img width="3228" height="1346" alt="image" src="https://github.com/user-attachments/assets/836a9816-ddb6-4bdf-b460-6050b62c57f4" /> - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ``` == NO RELEASE NOTE == ```
6 tasks
unidevel
added a commit
that referenced
this pull request
Aug 29, 2025
## Description This PR is [the fix from branch release-0.294]( #25900), to fix maven release issues ## Motivation and Context Merge the fix from release branch into master branch ## Impact Newer releases ## Test Plan Tested with release 0.294 ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
…#25902) ## Description This PR update the github action to publish maven artifacts with central publishing method, since maven repo doesn't allow executable jar(with shell script) to be published, so we will create a github release and publish the jars Need fix in release branch: prestodb#25900 Sample release for executable jars https://github.com/unix280/presto/releases ## Motivation and Context ## Impact Release 0.294 ## Test Plan Tested the github release in myrepo: https://github.com/unix280/presto/actions/runs/17272968441 Tested the maven publishing in local env ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description This PR is [the fix from branch release-0.294]( prestodb#25900), to fix maven release issues ## Motivation and Context Merge the fix from release branch into master branch ## Impact Newer releases ## Test Plan Tested with release 0.294 ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After migrated the central publishing, the executable jar(with shell script) files can not be published because of the maven repository limitation
Motivation and Context
This PR exclude the jars with shell script by adding a profile
executable-jar, and add a dummy file so that the java doc can be generated for publishingImpact
Release 0.294
Test Plan
Manually tested
Contributor checklist
Release Notes