Fix recoverable execution and enable flaky test in TestHiveRecoverableExecution#22314
Conversation
| }); | ||
| } | ||
| else { | ||
| LOG.info("The lifeSpanAndStage %s has been committed before", LifespanAndStage.fromTableCommitContext(tableCommitContext)); |
There was a problem hiding this comment.
Since this isn't actionable and no one needs to read this, this doesn't seem worth an info log. Debug level at most, but better yet nothing at all.
There was a problem hiding this comment.
Sure, the log is removed! Thanks for the suggestion.
7e909fc to
74ea3da
Compare
74ea3da to
7d1760f
Compare
|
Possibly flaky: [ERROR] TestPrestoNativeJoinQueries>AbstractTestNativeJoinQueries.testAntiJoin:86->AbstractTestQueryFramework.assertQuery:159 Execution of 'actual' query failed: SELECT * FROM lineitem WHERE linenumber = 3 OR orderkey NOT IN (SELECT orderkey FROM orders WHERE (orderkey + custkey) % 2 = 0) |
Seems unrelated. |
Description
A committed
LIFESPAN_COMMITtask may happens losing contact and being rescheduled. TableFinishOperator should handle this situation and do not try to make statistics for it again. Or we would meet the error described in #20466 and #20272.This PR fix #20466 and #20272.
Test Plan
testCreateBucketedTableandtestInsertBucketedTableinTestHiveRecoverableExecutionContributor checklist
Release Notes