diff --git a/presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java b/presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java index 8cc3c58af6794..8110445f42084 100644 --- a/presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java +++ b/presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java @@ -1125,17 +1125,17 @@ public SystemSessionProperties( value -> value != null ? value.toString() : null), booleanProperty( ENABLE_DYNAMIC_FILTERING, - "Experimental: Enable dynamic filtering", + "Enable dynamic filtering", featuresConfig.isEnableDynamicFiltering(), false), integerProperty( DYNAMIC_FILTERING_MAX_PER_DRIVER_ROW_COUNT, - "Experimental: maximum number of build-side rows to be collected for dynamic filtering per-driver", + "Maximum number of build-side rows to be collected for dynamic filtering per-driver", featuresConfig.getDynamicFilteringMaxPerDriverRowCount(), false), new PropertyMetadata<>( DYNAMIC_FILTERING_MAX_PER_DRIVER_SIZE, - "Experimental: maximum number of bytes to be collected for dynamic filtering per-driver", + "Maximum number of bytes to be collected for dynamic filtering per-driver", VARCHAR, DataSize.class, featuresConfig.getDynamicFilteringMaxPerDriverSize(), diff --git a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java index 1014075240a99..a1fa56e46f6cb 100644 --- a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java +++ b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java @@ -16,6 +16,7 @@ import com.facebook.airlift.configuration.Config; import com.facebook.airlift.configuration.ConfigDescription; import com.facebook.airlift.configuration.DefunctConfig; +import com.facebook.airlift.configuration.LegacyConfig; import com.facebook.presto.common.function.OperatorType; import com.facebook.presto.operator.aggregation.arrayagg.ArrayAggGroupImplementation; import com.facebook.presto.operator.aggregation.histogram.HistogramGroupImplementation; @@ -1471,7 +1472,8 @@ public boolean isEnableDynamicFiltering() return enableDynamicFiltering; } - @Config("experimental.enable-dynamic-filtering") + @Config("enable-dynamic-filtering") + @LegacyConfig("experimental.enable-dynamic-filtering") public FeaturesConfig setEnableDynamicFiltering(boolean value) { this.enableDynamicFiltering = value; @@ -1483,7 +1485,8 @@ public int getDynamicFilteringMaxPerDriverRowCount() return dynamicFilteringMaxPerDriverRowCount; } - @Config("experimental.dynamic-filtering-max-per-driver-row-count") + @Config("dynamic-filtering-max-per-driver-row-count") + @LegacyConfig("experimental.dynamic-filtering-max-per-driver-row-count") public FeaturesConfig setDynamicFilteringMaxPerDriverRowCount(int dynamicFilteringMaxPerDriverRowCount) { this.dynamicFilteringMaxPerDriverRowCount = dynamicFilteringMaxPerDriverRowCount; @@ -1496,7 +1499,8 @@ public DataSize getDynamicFilteringMaxPerDriverSize() return dynamicFilteringMaxPerDriverSize; } - @Config("experimental.dynamic-filtering-max-per-driver-size") + @Config("dynamic-filtering-max-per-driver-size") + @LegacyConfig("experimental.dynamic-filtering-max-per-driver-size") public FeaturesConfig setDynamicFilteringMaxPerDriverSize(DataSize dynamicFilteringMaxPerDriverSize) { this.dynamicFilteringMaxPerDriverSize = dynamicFilteringMaxPerDriverSize; @@ -1508,7 +1512,8 @@ public int getDynamicFilteringRangeRowLimitPerDriver() return dynamicFilteringRangeRowLimitPerDriver; } - @Config("experimental.dynamic-filtering-range-row-limit-per-driver") + @Config("dynamic-filtering-range-row-limit-per-driver") + @LegacyConfig("experimental.dynamic-filtering-range-row-limit-per-driver") @ConfigDescription("Maximum number of build-side rows per driver up to which min and max values will be collected for dynamic filtering") public FeaturesConfig setDynamicFilteringRangeRowLimitPerDriver(int dynamicFilteringRangeRowLimitPerDriver) { diff --git a/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java b/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java index 872ae828394e6..d95ca5feef2ba 100644 --- a/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java +++ b/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java @@ -244,10 +244,10 @@ public void testExplicitPropertyMappings() .put("experimental.iterative-optimizer-enabled", "false") .put("experimental.iterative-optimizer-timeout", "10s") .put("experimental.runtime-optimizer-enabled", "true") - .put("experimental.enable-dynamic-filtering", "true") - .put("experimental.dynamic-filtering-max-per-driver-row-count", "256") - .put("experimental.dynamic-filtering-max-per-driver-size", "64kB") - .put("experimental.dynamic-filtering-range-row-limit-per-driver", "1000") + .put("enable-dynamic-filtering", "true") + .put("dynamic-filtering-max-per-driver-row-count", "256") + .put("dynamic-filtering-max-per-driver-size", "64kB") + .put("dynamic-filtering-range-row-limit-per-driver", "1000") .put("experimental.fragment-result-caching-enabled", "true") .put("experimental.enable-stats-calculator", "false") .put("experimental.enable-stats-collection-for-temporary-table", "true")