Skip to content

Commit d0fc8b2

Browse files
fix: Add session property back native_max_partial_aggregation_memory (#26389)
## Description <!---Describe your changes in detail--> Add session property that was accidentally removed in #26087 Basic insertion does not include partition transform, metrics, sort order. ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == RELEASE NOTES == Prestissimo (Native Execution) Changes * Add back session property native_max_partial_aggregation_memory for Presto C++. ```
1 parent 8f97491 commit d0fc8b2

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

presto-main-base/src/main/java/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,11 @@ public NativeWorkerSessionPropertyProvider(FeaturesConfig featuresConfig)
261261
"preferred_output_batch_bytes and average row size estimates.",
262262
10000,
263263
!nativeExecution),
264+
longProperty(
265+
NATIVE_MAX_PARTIAL_AGGREGATION_MEMORY,
266+
"The max partial aggregation memory when data reduction is not optimal.",
267+
1L << 24,
268+
!nativeExecution),
264269
longProperty(
265270
NATIVE_MAX_EXTENDED_PARTIAL_AGGREGATION_MEMORY,
266271
"The max partial aggregation memory when data reduction is optimal.",

0 commit comments

Comments
 (0)