Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore filtering trumps explicit lists of files #1327

Open
mparry opened this issue Jan 10, 2025 · 0 comments
Open

.gitignore filtering trumps explicit lists of files #1327

mparry opened this issue Jan 10, 2025 · 0 comments

Comments

@mparry
Copy link

mparry commented Jan 10, 2025

If you specify some files to be copied in a files.source section in a test, this is silently filtered against .gitignore and that can end up overriding the list that you've explicitly given. I expect there may be other instances of this, hence the general issue title.

Of course, this will generally be due to user error - as it was in my case, in fact - but it took a while to figure out what was going on, given the lack of output about the filtering that had occurred.

I think it's fine to do this when considering files to be included in the package, say, and it may be reasonable to do it when a directory is given in files.source rather than an actual file, but I do think something different should happen for files at least - e.g. a warning or error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant