Support cmake-js #75
Open
Support cmake-js #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I prefer the generic approach of #7. |
AFAICT that removes all build support and instead the user needs to define their own external script command? That approach is quite a breaking change as all users of prebuildify would need to all specify (the same) replacement build script externally. This feels opaque and not very user friendly. If there were a lot of common build backends, I can see the benefit of that approach, but I'm not aware of anything outside of just node-gyp and cmake-js. Another benefit of this approach is it aligns with the existing prebuild package. |
|
? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
This PR adds support for driving
cmake-jsin the same way asprebuildby using the--backendflag. e.g.: