Remove use of env.npm_config_argv for npm 7

Instead use npm_config_* which works as far back as npm > 0.1.7.
It translates command line flags to environment variables, where:

--foo becomes npm_config_foo='true'
--no-foo becomes npm_config_foo=''
--foo=false becomes npm_config_foo=''

Author: vweevers

Diff for: rc.js

@@ -4,49 +4,32 @@ var detectLibc = require('detect-libc')
 var napi = require('napi-build-utils')
 
 var env = process.env
-
 var libc = env.LIBC || (detectLibc.isNonGlibcLinux && detectLibc.family) || ''
 
-// Get `prebuild-install` arguments that were passed to the `npm` command
-if (env.npm_config_argv) {
-  var npmargs = ['prebuild', 'compile', 'build-from-source', 'debug', 'verbose']
-  try {
-    var npmArgv = JSON.parse(env.npm_config_argv).cooked
-    for (var i = 0; i < npmargs.length; ++i) {
-      if (npmArgv.indexOf('--' + npmargs[i]) !== -1) {
-        process.argv.push('--' + npmargs[i])
-      }
-      if (npmArgv.indexOf('--no-' + npmargs[i]) !== -1) {
-        process.argv.push('--no-' + npmargs[i])
-      }
-    }
-    if ((i = npmArgv.indexOf('--download')) !== -1) {
-      process.argv.push(npmArgv[i], npmArgv[i + 1])
-    }
-  } catch (e) { }
-}
-
 // Get the configuration
 module.exports = function (pkg) {
   var pkgConf = pkg.config || {}
-  var sourceBuild = env.npm_config_build_from_source
-  var buildFromSource = sourceBuild === pkg.name || sourceBuild === 'true'
+
+  // TODO: remove compile and prebuild aliases?
+  var buildFromSource = env.npm_config_build_from_source || env.npm_config_compile
+
   var rc = require('rc')('prebuild-install', {
     target: pkgConf.target || env.npm_config_target || process.versions.node,
     runtime: pkgConf.runtime || env.npm_config_runtime || 'node',
     arch: pkgConf.arch || env.npm_config_arch || process.arch,
     libc: libc,
     platform: env.npm_config_platform || process.platform,
-    debug: false,
+    debug: env.npm_config_debug === 'true',
     force: false,
-    verbose: false,
-    prebuild: true,
-    compile: buildFromSource,
+    verbose: env.npm_config_verbose === 'true',
+    prebuild: env.npm_config_prebuild !== '',
+    compile: buildFromSource === pkg.name || buildFromSource === 'true',
     path: '.',
     proxy: env.npm_config_proxy || env['http_proxy'] || env['HTTP_PROXY'],
     'https-proxy': env.npm_config_https_proxy || env['https_proxy'] || env['HTTPS_PROXY'],
     'local-address': env.npm_config_local_address,
-    'tag-prefix': 'v'
+    'tag-prefix': 'v',
+    download: env.npm_config_download
   }, minimist(process.argv, {
     alias: {
       target: 't',

Diff for: test/rc-test.js

@@ -55,11 +55,11 @@ test('npm args are passed on from npm environment into rc', function (t) {
   ].join(' ')
 
   runRc(t, args, {}, function (rc) {
-    t.equal(rc['build-from-source'], true, '--build-from-source works')
     t.equal(rc.compile, true, 'compile should be true')
     t.equal(rc.debug, true, 'debug should be true')
     t.equal(rc.verbose, true, 'verbose should be true')
     t.equal(rc.download, 'https://foo.bar', 'download is set')
+    t.equal(rc.prebuild, true, 'prebuild is true')
     t.end()
   })
 })
@@ -140,16 +140,16 @@ function runRc (t, args, env, cb) {
     if (err) throw err
 
     var npm = process.platform === 'win32' ? 'npm.cmd' : 'npm'
-    var cmd = npm + ' run --silent install'
+    var cmd = npm + ' run install'
 
     env = Object.assign(cleanEnv(process.env), env)
 
     exec(cmd, { env, cwd: tmp }, function (err, stdout, stderr) {
       t.error(err, 'no error')
-      t.equal(stderr.toString().trim(), '', 'no stderr')
+      t.equal(stderr.trim(), '', 'no stderr')
 
       try {
-        var result = JSON.parse(stdout.toString())
+        var result = JSON.parse(stdout.slice(stdout.indexOf('{')))
       } catch (e) {
         return t.fail(e)
       }