-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"No native build was found" during yarn install --verbose
is disconcerting
#42
Comments
What's your suggestion for updating this? Not fully sure I follow. If users use the |
No, no! I'm saying it's worth taking extra steps to avoid printing the error, even in |
I've found it useful many times. Would it help to tweak the message? |
That would be fine too! Honestly the biggest problem is that it's displayed as an Error (of course it is, that's what was thrown), and someone who doesn't know about node-gyp-build might think that's an actual error during the build process rather than just part of the detection logic. |
node-gyp-build
-the-executable currently detects whether there's a build or prebuild available by running a script that loadsnode-gyp-build
-the-library, which (reasonably) throws an error if the build/prebuild is missing. It also only shows stderr output from this script in "verbose" mode, which is also reasonable. However, this means thatyarn install --verbose
of a library usingnode-gyp-build
can end up with an "error" in the log output, even though it's just hownode-gyp-build
is detecting whether there's a build or not. This can lead to confusion, especially if there's an actual problem later on (see signalapp/libsignal#456).I personally think the best solution is to separate the error-throwing from the search. This would allow other errors to still be displayed, as well as distinguishing between "the build is missing" and "the build is present but cannot be loaded" (rebuilding may not help in the latter case).
The text was updated successfully, but these errors were encountered: