From cb13cd24a959a5860e3db3fc6d868bfa1a4017e8 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:30:13 +0100 Subject: [PATCH 1/8] try to fix benchmarks --- .github/workflows/benchmarks.yml | 2 +- .github/workflows/release.yml | 2 +- .github/workflows/run-bench.yml | 6 +++--- .github/workflows/single-bench.yml | 8 ++++---- src/render.js | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 51f0ce9a4c..93fad719b9 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -43,7 +43,7 @@ jobs: required: false - run: mv preact.tgz preact-main.tgz - name: Upload base preact package - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: bench-environment path: preact-main.tgz diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index bdacd280ff..9cb99bc77e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,7 +11,7 @@ jobs: needs: build steps: - uses: actions/checkout@v4 - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: npm-package - name: Create draft release diff --git a/.github/workflows/run-bench.yml b/.github/workflows/run-bench.yml index 663988ffd9..de359d2149 100644 --- a/.github/workflows/run-bench.yml +++ b/.github/workflows/run-bench.yml @@ -37,7 +37,7 @@ jobs: node-version-file: 'package.json' cache: 'npm' cache-dependency-path: '**/package-lock.json' - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: bench-environment - name: Install deps @@ -49,7 +49,7 @@ jobs: export CHROMEDRIVER_FILEPATH=$(which chromedriver) npm run bench ${{ inputs.benchmark }}.html -- --trace=${{ inputs.trace }} - name: Upload results - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: results path: benches/results/${{ inputs.benchmark }}.json @@ -60,7 +60,7 @@ jobs: working-directory: benches run: '[ -d logs ] && tar -zcvf ${{ inputs.benchmark}}_logs.tgz logs || echo "No logs found"' - name: Upload logs - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{ inputs.benchmark}}_logs path: benches/${{ inputs.benchmark}}_logs.tgz diff --git a/.github/workflows/single-bench.yml b/.github/workflows/single-bench.yml index 5682a6f7d6..8b9906dd36 100644 --- a/.github/workflows/single-bench.yml +++ b/.github/workflows/single-bench.yml @@ -57,12 +57,12 @@ jobs: timeout-minutes: 5 steps: - name: Download locally built preact package - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: npm-package - run: mv preact.tgz preact-local.tgz - name: Upload locally built preact package - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: bench-environment path: preact-local.tgz @@ -73,12 +73,12 @@ jobs: echo "====================" ls -al - name: Download base package - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: base-npm-package - run: mv preact.tgz preact-main.tgz - name: Upload base preact package - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: bench-environment path: preact-main.tgz diff --git a/src/render.js b/src/render.js index 1ee326bc92..b77e187839 100644 --- a/src/render.js +++ b/src/render.js @@ -58,7 +58,7 @@ export function render(vnode, parentDom, replaceNode) { isHydrating, refQueue ); - + // test // Flush all queued effects commitRoot(commitQueue, vnode, refQueue); } From f7ecee6f0b123d19dd40213ecea89279f74d0812 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:34:52 +0100 Subject: [PATCH 2/8] empty commit test From cfce3d2de3bc3638694b2c4ffde76e8e420fe764 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:36:02 +0100 Subject: [PATCH 3/8] add overwrite --- .github/workflows/benchmarks.yml | 2 ++ .github/workflows/ci.yml | 1 + .github/workflows/run-bench.yml | 2 ++ .github/workflows/single-bench.yml | 2 ++ 4 files changed, 7 insertions(+) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 93fad719b9..ffb364b2ec 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -35,6 +35,7 @@ jobs: with: name: bench-environment path: preact-local.tgz + overwrite: true - name: Download base package uses: andrewiggins/download-base-artifact@v3 with: @@ -47,6 +48,7 @@ jobs: with: name: bench-environment path: preact-main.tgz + overwrite: true bench_todo: name: Bench todo diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ef15be011b..f5840f3fe2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,3 +60,4 @@ jobs: with: name: ${{ inputs.artifact_name || 'npm-package' }} path: preact.tgz + overwrite: true diff --git a/.github/workflows/run-bench.yml b/.github/workflows/run-bench.yml index de359d2149..b2cbcf678b 100644 --- a/.github/workflows/run-bench.yml +++ b/.github/workflows/run-bench.yml @@ -53,6 +53,7 @@ jobs: with: name: results path: benches/results/${{ inputs.benchmark }}.json + overwrite: true - name: Anaylze logs if present working-directory: benches run: '[ -d logs ] && npm run analyze ${{ inputs.benchmark }} || echo "No logs to analyze"' @@ -65,3 +66,4 @@ jobs: name: ${{ inputs.benchmark}}_logs path: benches/${{ inputs.benchmark}}_logs.tgz if-no-files-found: ignore + overwrite: true diff --git a/.github/workflows/single-bench.yml b/.github/workflows/single-bench.yml index 8b9906dd36..ad40f2c6b1 100644 --- a/.github/workflows/single-bench.yml +++ b/.github/workflows/single-bench.yml @@ -66,6 +66,7 @@ jobs: with: name: bench-environment path: preact-local.tgz + overwrite: true - name: Clear working directory run: | ls -al @@ -82,6 +83,7 @@ jobs: with: name: bench-environment path: preact-main.tgz + overwrite: true benchmark: name: Bench ${{ inputs.benchmark }} From 3707f85e34ee7970766f9b5e7e06cdcf10e5ef0f Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:42:21 +0100 Subject: [PATCH 4/8] Revert "update some actions to remove node 20 warnings (#4298)" This reverts commit c5f048366a8a02417125eb17829f472122938b82. --- .github/workflows/benchmarks.yml | 4 ++-- .github/workflows/ci.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index ffb364b2ec..3449c723ca 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -26,12 +26,12 @@ jobs: timeout-minutes: 5 steps: - name: Download locally built preact package - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v3 with: name: npm-package - run: mv preact.tgz preact-local.tgz - name: Upload locally built preact package - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: name: bench-environment path: preact-local.tgz diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f5840f3fe2..3e1930b06f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,7 +56,7 @@ jobs: npm pack --ignore-scripts mv preact-*.tgz preact.tgz - name: Upload npm package - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: name: ${{ inputs.artifact_name || 'npm-package' }} path: preact.tgz From 06e9d28626676a5ca4cc29fec4a34ea53a365a85 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:42:38 +0100 Subject: [PATCH 5/8] Revert "add overwrite" This reverts commit cfce3d2de3bc3638694b2c4ffde76e8e420fe764. --- .github/workflows/benchmarks.yml | 2 -- .github/workflows/ci.yml | 1 - .github/workflows/run-bench.yml | 2 -- .github/workflows/single-bench.yml | 2 -- 4 files changed, 7 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 3449c723ca..9304f535e2 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -35,7 +35,6 @@ jobs: with: name: bench-environment path: preact-local.tgz - overwrite: true - name: Download base package uses: andrewiggins/download-base-artifact@v3 with: @@ -48,7 +47,6 @@ jobs: with: name: bench-environment path: preact-main.tgz - overwrite: true bench_todo: name: Bench todo diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3e1930b06f..b32ee79ea0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,4 +60,3 @@ jobs: with: name: ${{ inputs.artifact_name || 'npm-package' }} path: preact.tgz - overwrite: true diff --git a/.github/workflows/run-bench.yml b/.github/workflows/run-bench.yml index b2cbcf678b..de359d2149 100644 --- a/.github/workflows/run-bench.yml +++ b/.github/workflows/run-bench.yml @@ -53,7 +53,6 @@ jobs: with: name: results path: benches/results/${{ inputs.benchmark }}.json - overwrite: true - name: Anaylze logs if present working-directory: benches run: '[ -d logs ] && npm run analyze ${{ inputs.benchmark }} || echo "No logs to analyze"' @@ -66,4 +65,3 @@ jobs: name: ${{ inputs.benchmark}}_logs path: benches/${{ inputs.benchmark}}_logs.tgz if-no-files-found: ignore - overwrite: true diff --git a/.github/workflows/single-bench.yml b/.github/workflows/single-bench.yml index ad40f2c6b1..8b9906dd36 100644 --- a/.github/workflows/single-bench.yml +++ b/.github/workflows/single-bench.yml @@ -66,7 +66,6 @@ jobs: with: name: bench-environment path: preact-local.tgz - overwrite: true - name: Clear working directory run: | ls -al @@ -83,7 +82,6 @@ jobs: with: name: bench-environment path: preact-main.tgz - overwrite: true benchmark: name: Bench ${{ inputs.benchmark }} From 32d46ad85822704c7d15e3edf7db93697a470cad Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:42:49 +0100 Subject: [PATCH 6/8] Revert "try to fix benchmarks" This reverts commit cb13cd24a959a5860e3db3fc6d868bfa1a4017e8. --- .github/workflows/benchmarks.yml | 2 +- .github/workflows/release.yml | 2 +- .github/workflows/run-bench.yml | 6 +++--- .github/workflows/single-bench.yml | 8 ++++---- src/render.js | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 9304f535e2..9c6624f674 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -43,7 +43,7 @@ jobs: required: false - run: mv preact.tgz preact-main.tgz - name: Upload base preact package - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: name: bench-environment path: preact-main.tgz diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9cb99bc77e..bdacd280ff 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,7 +11,7 @@ jobs: needs: build steps: - uses: actions/checkout@v4 - - uses: actions/download-artifact@v4 + - uses: actions/download-artifact@v3 with: name: npm-package - name: Create draft release diff --git a/.github/workflows/run-bench.yml b/.github/workflows/run-bench.yml index de359d2149..663988ffd9 100644 --- a/.github/workflows/run-bench.yml +++ b/.github/workflows/run-bench.yml @@ -37,7 +37,7 @@ jobs: node-version-file: 'package.json' cache: 'npm' cache-dependency-path: '**/package-lock.json' - - uses: actions/download-artifact@v4 + - uses: actions/download-artifact@v3 with: name: bench-environment - name: Install deps @@ -49,7 +49,7 @@ jobs: export CHROMEDRIVER_FILEPATH=$(which chromedriver) npm run bench ${{ inputs.benchmark }}.html -- --trace=${{ inputs.trace }} - name: Upload results - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: name: results path: benches/results/${{ inputs.benchmark }}.json @@ -60,7 +60,7 @@ jobs: working-directory: benches run: '[ -d logs ] && tar -zcvf ${{ inputs.benchmark}}_logs.tgz logs || echo "No logs found"' - name: Upload logs - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: name: ${{ inputs.benchmark}}_logs path: benches/${{ inputs.benchmark}}_logs.tgz diff --git a/.github/workflows/single-bench.yml b/.github/workflows/single-bench.yml index 8b9906dd36..5682a6f7d6 100644 --- a/.github/workflows/single-bench.yml +++ b/.github/workflows/single-bench.yml @@ -57,12 +57,12 @@ jobs: timeout-minutes: 5 steps: - name: Download locally built preact package - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v3 with: name: npm-package - run: mv preact.tgz preact-local.tgz - name: Upload locally built preact package - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: name: bench-environment path: preact-local.tgz @@ -73,12 +73,12 @@ jobs: echo "====================" ls -al - name: Download base package - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v3 with: name: base-npm-package - run: mv preact.tgz preact-main.tgz - name: Upload base preact package - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: name: bench-environment path: preact-main.tgz diff --git a/src/render.js b/src/render.js index b77e187839..1ee326bc92 100644 --- a/src/render.js +++ b/src/render.js @@ -58,7 +58,7 @@ export function render(vnode, parentDom, replaceNode) { isHydrating, refQueue ); - // test + // Flush all queued effects commitRoot(commitQueue, vnode, refQueue); } From 5d1db8d63c740c27a8405be043d696f581447d3f Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:43:44 +0100 Subject: [PATCH 7/8] test comment --- src/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/index.js b/src/index.js index e9cb50fd8e..5251e97689 100644 --- a/src/index.js +++ b/src/index.js @@ -11,3 +11,4 @@ export { cloneElement } from './clone-element'; export { createContext } from './create-context'; export { toChildArray } from './diff/children'; export { default as options } from './options'; +//test From 1385d373de384180638648ba89600766c8f6ba72 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:47:19 +0100 Subject: [PATCH 8/8] remove comment forcing bench runs --- src/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/index.js b/src/index.js index 5251e97689..e9cb50fd8e 100644 --- a/src/index.js +++ b/src/index.js @@ -11,4 +11,3 @@ export { cloneElement } from './clone-element'; export { createContext } from './create-context'; export { toChildArray } from './diff/children'; export { default as options } from './options'; -//test