-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nextjs] Preact renders 5x when error is thrown in render and cancels rendering route #3233
Comments
It looks like Next.js is repeatedly re-rendering the route (there are 5 calls to preact/src/diff/catch-error.js Line 24 in 7e33abd
Normally, I'd be down to remove this personally, though it's unfortunate to drop conditional error bubbling (kinda a useful feature) to get compat :/ |
Can confirm - my PR fixes this, we'll just need to figure out whether the change is something Preact can land without breaking stuff (since it affects how Suspense works). You can try it locally:
|
@developit any tips on what I should do here long-term? Is a fix in the works? |
Hello. Any updates on this? This problem still remains with Next 12.1.6, Preact 10.7.2 |
Hello guys, any updates? I'm facing the same issue. |
Describe the bug
This is a bug related to Preact with Next.JS. If there's a better place to post this please let me know :) When an exception is throw in the render phase of a clientside rendered page the Next.JS
pages/_error
fails to render.To Reproduce
Steps to reproduce the behavior:
Expected behavior
pages/failing
render oncepages/_error
The text was updated successfully, but these errors were encountered: