From cb13cd24a959a5860e3db3fc6d868bfa1a4017e8 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sun, 17 Mar 2024 16:30:13 +0100 Subject: [PATCH] try to fix benchmarks --- .github/workflows/benchmarks.yml | 2 +- .github/workflows/release.yml | 2 +- .github/workflows/run-bench.yml | 6 +++--- .github/workflows/single-bench.yml | 8 ++++---- src/render.js | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 51f0ce9a4c..93fad719b9 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -43,7 +43,7 @@ jobs: required: false - run: mv preact.tgz preact-main.tgz - name: Upload base preact package - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: bench-environment path: preact-main.tgz diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index bdacd280ff..9cb99bc77e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,7 +11,7 @@ jobs: needs: build steps: - uses: actions/checkout@v4 - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: npm-package - name: Create draft release diff --git a/.github/workflows/run-bench.yml b/.github/workflows/run-bench.yml index 663988ffd9..de359d2149 100644 --- a/.github/workflows/run-bench.yml +++ b/.github/workflows/run-bench.yml @@ -37,7 +37,7 @@ jobs: node-version-file: 'package.json' cache: 'npm' cache-dependency-path: '**/package-lock.json' - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: bench-environment - name: Install deps @@ -49,7 +49,7 @@ jobs: export CHROMEDRIVER_FILEPATH=$(which chromedriver) npm run bench ${{ inputs.benchmark }}.html -- --trace=${{ inputs.trace }} - name: Upload results - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: results path: benches/results/${{ inputs.benchmark }}.json @@ -60,7 +60,7 @@ jobs: working-directory: benches run: '[ -d logs ] && tar -zcvf ${{ inputs.benchmark}}_logs.tgz logs || echo "No logs found"' - name: Upload logs - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{ inputs.benchmark}}_logs path: benches/${{ inputs.benchmark}}_logs.tgz diff --git a/.github/workflows/single-bench.yml b/.github/workflows/single-bench.yml index 5682a6f7d6..8b9906dd36 100644 --- a/.github/workflows/single-bench.yml +++ b/.github/workflows/single-bench.yml @@ -57,12 +57,12 @@ jobs: timeout-minutes: 5 steps: - name: Download locally built preact package - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: npm-package - run: mv preact.tgz preact-local.tgz - name: Upload locally built preact package - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: bench-environment path: preact-local.tgz @@ -73,12 +73,12 @@ jobs: echo "====================" ls -al - name: Download base package - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: base-npm-package - run: mv preact.tgz preact-main.tgz - name: Upload base preact package - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: bench-environment path: preact-main.tgz diff --git a/src/render.js b/src/render.js index 1ee326bc92..b77e187839 100644 --- a/src/render.js +++ b/src/render.js @@ -58,7 +58,7 @@ export function render(vnode, parentDom, replaceNode) { isHydrating, refQueue ); - + // test // Flush all queued effects commitRoot(commitQueue, vnode, refQueue); }