Merge branch 'main' into test-skipping-lifecycles-for-funcs

compat/server.js

@@ -9,7 +9,18 @@ try {
 	);
 }
 
+var renderToPipeableStream;
+try {
+	const mod = require('preact-render-to-string/stream-node');
+	renderToPipeableStream = mod.default || mod.renderToPipeableStream || mod;
+} catch (e) {
+	throw Error(
+		'renderToPipeableStream() error: update "preact-render-to-string" dependency to at least 6.5.0.'
+	);
+}
+
 module.exports = {
 	renderToString: renderToString,
-	renderToStaticMarkup: renderToString
+	renderToStaticMarkup: renderToString,
+	renderToPipeableStream: renderToPipeableStream
 };

compat/server.mjs

@@ -5,7 +5,10 @@ export {
 	renderToString as renderToStaticMarkup
 } from 'preact-render-to-string';
 
+export { renderToPipeableStream } from 'preact-render-to-string/stream-node'
+
 export default {
 	renderToString,
-	renderToStaticMarkup: renderToString
+	renderToStaticMarkup: renderToString,
+	renderToPipeableStream
 };

package.json

@@ -241,7 +241,7 @@
     "npm-merge-driver-install": "^1.1.1",
     "npm-run-all": "^4.0.0",
     "oxlint": "^0.3.4",
-    "preact-render-to-string": "^5.2.5",
+    "preact-render-to-string": "^6.5.0",
     "prop-types": "^15.7.2",
     "sade": "^1.7.4",
     "sinon": "^9.2.3",

src/create-context.js

@@ -18,29 +18,19 @@ export function createContext(defaultValue, contextId) {
 		/** @type {FunctionComponent} */
 		Provider(props) {
 			if (!this.getChildContext) {
-				/** @type {Component[]} */
+				/** @type {Component[] | null} */
 				let subs = [];
 				let ctx = {};
 				ctx[contextId] = this;
 
 				this.getChildContext = () => ctx;
 
+				this.componentWillUnmount = () => {
+					subs = null;
+				};
+
 				this.shouldComponentUpdate = function (_props) {
 					if (this.props.value !== _props.value) {
-						// I think the forced value propagation here was only needed when `options.debounceRendering` was being bypassed:
-						// https://github.com/preactjs/preact/commit/4d339fb803bea09e9f198abf38ca1bf8ea4b7771#diff-54682ce380935a717e41b8bfc54737f6R358
-						// In those cases though, even with the value corrected, we're double-rendering all nodes.
-						// It might be better to just tell folks not to use force-sync mode.
-						// Currently, using `useContext()` in a class component will overwrite its `this.context` value.
-						// subs.some(c => {
-						// 	c.context = _props.value;
-						// 	enqueueRender(c);
-						// });
-
-						// subs.some(c => {
-						// 	c.context[contextId] = _props.value;
-						// 	enqueueRender(c);
-						// });
 						subs.some(c => {
 							c._force = true;
 							enqueueRender(c);
@@ -52,7 +42,9 @@ export function createContext(defaultValue, contextId) {
 					subs.push(c);
 					let old = c.componentWillUnmount;
 					c.componentWillUnmount = () => {
-						subs.splice(subs.indexOf(c), 1);
+						if (subs) {
+							subs.splice(subs.indexOf(c), 1);
+						}
 						if (old) old.call(c);
 					};
 				};

src/diff/props.js

@@ -116,6 +116,7 @@ export function setProperty(dom, name, value, oldValue, namespace) {
 			name != 'rowSpan' &&
 			name != 'colSpan' &&
 			name != 'role' &&
+			name != 'popover' &&
 			name in dom
 		) {
 			try {
@@ -135,7 +136,7 @@ export function setProperty(dom, name, value, oldValue, namespace) {
 		if (typeof value == 'function') {
 			// never serialize functions as attribute values
 		} else if (value != null && (value !== false || name[4] === '-')) {
-			dom.setAttribute(name, value);
+			dom.setAttribute(name, name == 'popover' && value == true ? '' : value);
 		} else {
 			dom.removeAttribute(name);
 		}

test/browser/render.test.js

@@ -472,6 +472,21 @@ describe('render()', () => {
 		expect(scratch.firstChild.spellcheck).to.equal(false);
 	});
 
+	it('should support popover auto', () => {
+		render(<div popover="auto" />, scratch);
+		expect(scratch.innerHTML).to.equal("<div popover=\"auto\"></div>");
+	});
+
+	it('should support popover true boolean', () => {
+		render(<div popover />, scratch);
+		expect(scratch.innerHTML).to.equal("<div popover=\"\"></div>");
+	});
+
+	it('should support popover false boolean', () => {
+		render(<div popover={false} />, scratch);
+		expect(scratch.innerHTML).to.equal("<div></div>");
+	});
+
 	// Test for preactjs/preact#4340
 	it('should respect defaultValue in render', () => {
 		scratch.innerHTML = '<input value="foo">';