Skip to content

fix: Resolve issue with shadow DOM #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschristian merged 3 commits into from
Mar 12, 2025
Merged

fix: Resolve issue with shadow DOM #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d43ce00
fix: Resolve issue with shadow DOM
Jentob Mar 11, 2025
5250fa2
test: Add test case for shadow DOM
Jentob Mar 12, 2025
812fc6c
Update src/router.js
Jentob Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const UPDATE = (state, url) => {
return state;
}

const link = url.target.closest('a[href]'),
const link = url.composedPath().find(el => el.nodeName == 'A' && el.href),
href = link && link.getAttribute('href');
if (
!link ||
Expand Down
35 changes: 35 additions & 0 deletions test/router.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,41 @@ describe('Router', () => {
await sleep(10);
expect(scratch).to.have.property('textContent', 'data');
});

it('should intercept clicks on links inside open shadow DOM', async () => {
const shadowlink = document.createElement('a');
shadowlink.href = '/shadow';
shadowlink.textContent = 'Shadow Link';
shadowlink.addEventListener('click', e => e.preventDefault());

const attachShadow = (el) => {
if (!el || el.shadowRoot) return;
const shadowroot = el.attachShadow({ mode: 'open' });
shadowroot.appendChild(shadowlink);
}

const Home = sinon.fake(() => <div ref={attachShadow}></div>);
const Shadow = sinon.fake(() => <div>Shadow Route</div>);

render(
<LocationProvider>
<Router>
<Route path="/" component={Home} />
<Route path="/shadow" component={Shadow}/>
</Router>
<ShallowLocation />
</LocationProvider>,
scratch
);

shadowlink.click();

await sleep(1);

expect(loc).to.deep.include({ url: '/shadow' });
expect(Shadow).to.have.been.calledOnce;
expect(scratch).to.have.property('textContent', 'Shadow Route');
});
});

const MODE_HYDRATE = 1 << 5;
Expand Down