chore: Updating html-webpack-plugin to v4 #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 438882c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
feat/html-webpack-plugin
branch
2 times, most recently
from
f583dcd to
f8d3a0a
Compare
|
Yeah, I think critters is the issue I ran into as well |
|
Yeah, it didn't support v4 until a couple weeks ago. With that support there was a significant refactor that still has some bugs that need to be fixed, so gotta wait some more :/ |
rschristian
force-pushed
the
feat/html-webpack-plugin
branch
2 times, most recently
from
5977e66 to
d2cdd7c
Compare
rschristian
commented
Nov 12, 2021
Comment on lines
-257
to
+255
| additionalStylesheets: ['*.css'], | ||
| additionalStylesheets: ['route-*.css'], |
There was a problem hiding this comment.
Critters has always duplicated the styles in bundle.css due to it too matching this pattern, but historically has deduped through using cssnano as means to compress. cssnano is no longer in use, so we're getting duplicate CSS. See critters/88.
Not yet sure if this is a regression to be fixed in Critters or not, but we can get around it by only matching chunk split CSS, which I believe is the intention anyhow?
rschristian
force-pushed
the
feat/html-webpack-plugin
branch
2 times, most recently
from
63f001e to
9ca01e8
Compare
rschristian
force-pushed
the
feat/html-webpack-plugin
branch
17 times, most recently
from
2651725 to
094058c
Compare
rschristian
force-pushed
the
feat/html-webpack-plugin
branch
from
094058c to
e461df5
Compare
rschristian
added a commit
that referenced
this pull request
Feb 2, 2022
rschristian
added a commit
that referenced
this pull request
Feb 2, 2022
rschristian
added a commit
that referenced
this pull request
Feb 2, 2022
rschristian
added a commit
that referenced
this pull request
Feb 2, 2022
rschristian
added a commit
that referenced
this pull request
Feb 9, 2022
rschristian
added a commit
that referenced
this pull request
Apr 15, 2022
rschristian
added a commit
that referenced
this pull request
Apr 15, 2022
rschristian
added a commit
that referenced
this pull request
Apr 15, 2022
rschristian
added a commit
that referenced
this pull request
May 16, 2022
rschristian
added a commit
that referenced
this pull request
Jun 6, 2022
rschristian
added a commit
that referenced
this pull request
Jul 7, 2022
rschristian
added a commit
that referenced
this pull request
Aug 1, 2022
rschristian
added a commit
that referenced
this pull request
Aug 18, 2022
rschristian
added a commit
that referenced
this pull request
Nov 18, 2022
rschristian
added a commit
that referenced
this pull request
Dec 13, 2022
rschristian
added a commit
that referenced
this pull request
Dec 20, 2022
rschristian
added a commit
that referenced
this pull request
Dec 24, 2022
rschristian
added a commit
that referenced
this pull request
Dec 24, 2022
rschristian
added a commit
that referenced
this pull request
Dec 24, 2022
rschristian
added a commit
that referenced
this pull request
Jan 6, 2023
rschristian
added a commit
that referenced
this pull request
Jan 7, 2023
rschristian
added a commit
that referenced
this pull request
Jan 9, 2023
rschristian
added a commit
that referenced
this pull request
Jan 9, 2023
rschristian
added a commit
that referenced
this pull request
Jan 31, 2023
rschristian
added a commit
that referenced
this pull request
Feb 2, 2023
rschristian
added a commit
that referenced
this pull request
Oct 10, 2023
rschristian
added a commit
that referenced
this pull request
Oct 10, 2023
* Chore: Updating html-webpack-plugin to v4 (#1608) * chore: Correcting changeset * feat: webpack v5 (#1645) * feat: webpack-v5 * test: Update tests * docs: Updating docs to reflect changes * chore: Removing optimize-plugin local patch * refactor: Determine CSS module by filename, not directory (#1714) * refactor: Determine CSS module by filename, not directory * docs: Adding changeset * refactor: Project creation pull from templates 'main' branch * test: Updating tests * revert: Accidentally removed log message * refactor: Extracting project creation out to own package (#1708) * refactor: Extracting out project creation to own package * docs: Adding changeset * refactor: Misc edits to common deps & workspace helper scripts * test: Fixing 'create' test suite * ci: Increase minimum Node version * chore: Fix typos * docs: Update ReadMe instructions * chore: Better (and untaken) package name * docs: Update changeset * test: Update 'create' test suite & build output hashes * docs: Expounding upon changeset * refactor: Drop Preact 8 support (#1716) * refactor: Drops support for Preact v8 * docs: Adding changeset * refactor: Switch to automatic runtime JSX transform (#1725) * refactor: Switch over to automatic runtime transform for JSX * test: Removing `h` imports from test suite * docs: Adding changeset * docs: Adding readme for create-cli (#1728) * docs: Adding readme for create-cli * feat: Initial publish * fix: Correcting broken readme links * refactor: Disable hashing ssr-build's css (#1733) * refactor: Disable hashing ssr-build's css * docs: Adding changeset * test: Fix unrelated change from altered template * refactor: Remove `--preload` flag (#1737) * refactor: Removes `--preload` flag & functionality * docs: Adding changeset * docs: Updating readme for removal of preload * refactor: Separate internal concepts of config and env (#1734) * refactor: Separate internal concepts of config and env * docs: Adding changeset * refactor: prune flags (#1752) * refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset * feat: Improved errors and warnings (#1758) * refactor: Better root error handling * refactor: Switch prerender plugin to be async for error gen * refactor: Simplify & improve compilation messages * refactor: Bump Node version, remove `src` arg in build & watch, and misc housekeeping (#1753) * refactor: Drop rimraf for built-in fs.rm * refactor: Drop src argument in build & watch cmds * refactor: Extract info cmd from CLI entrypoint * refactor: Remove update-notifier * refactor: Switch from fs.promises to fs/promises * docs: Adding changeset * refactor: Move EJS into user templates (`template.html`) (#1768) * refactor: Merging EJS templates and switcing preferred template extension to .ejs * test: Fixing test suite to reflect latest changes * chore: Cleaning * docs: Updating ReadMe * docs: Adding changeset * refactor: Add error message for <% preact.(head|body)End %> * chore: Publishing cli & create-cli * Refactor: Enable Prefresh by Default (#1772) * refactor: Enables HMR via Prefresh by default * docs: Adding changeset * test: Updating tests to reflect changes to templates * refactor: Remove Critters (perhaps temporarily) (#1778) * refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset * chore: Publish v4.0.0-next.2 * refactor: Vendor Critters so that 7c811ac can be reverted (#1780) * docs: Remove CLI beta note from readme * docs: Bump minimum Node version listed in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bumping
html-webpack-pluginto v4Did you add tests for your changes?
Existing should cover
Summary
Rebase of #1466, with some additional changes to finish things off
Closes #1551
Need a new release from critters, now that GoogleChromeLabs/critters#87 has been merged.Possibly need action on/wait for GoogleChromeLabs/critters#88 if my work around isn't viable?