Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL Support #73

Open
Daltz333 opened this issue Jan 9, 2021 · 4 comments
Open

Add RTL Support #73

Daltz333 opened this issue Jan 9, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Daltz333
Copy link

Daltz333 commented Jan 9, 2021

Our project supports many languages. Several of these are Right-to-Left based languages. We have custom CSS to handle if the documentation language is specified as RTL or not to handle this. In the future, I'd like to consider moving toward furo, however I'd rather not recreate the complex CSS required for RTL support.

I'd like to request RTL CSS be added to furo.

@Daltz333 Daltz333 added the enhancement New feature or request label Jan 9, 2021
@pradyunsg
Copy link
Owner

I'd be very happy to accept a PR for this. If someone could provide a demo documentation, with instructions on how to perform the build, that'd be great too! :)

@pradyunsg
Copy link
Owner

@Daltz333 Could you provide me with an RTL documentation set for me to test with?

@Daltz333
Copy link
Author

This is our current RTL documentation set. If you'd like, I can open a branch with it currently in furo.

https://docs.wpilib.org/he/stable/

@pradyunsg
Copy link
Owner

pradyunsg commented Jan 21, 2021

Ah thanks!

For future self-reference, the steps to build those docs with a specific language are at https://github.com/wpilibsuite/frc-docs-translations/#building-locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants