Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online results changes should be watched (and shown) even when not at the results screen #26743

Closed
peppy opened this issue Jan 27, 2024 · 0 comments · Fixed by #27156
Closed
Assignees
Labels
priority:1 Very important. Feels bad without fix. Affects the majority of users. type:behavioural type:online

Comments

@peppy
Copy link
Member

peppy commented Jan 27, 2024

Currently, we have a flow for watching for statistics changes of the logged in user, but it's only acted on if the user remains at the results screen. This isn't always the case, as users regularly leave the results screen before processing completes. In such a case, two things go wrong:

  • They won't be aware of the change in statistics (in stable this is shown in a very jank way, with numbers appearing in the middle of nowhere, but it is shown and people are used to seeing it)
  • Because the stats aren't updated, when they play the next beatmap it will include the difference in stats from the previous play, resulting in incorrectly high numbers. This was reported in private testing as "a loved map gave me pp" or similar.
@peppy peppy added type:online type:behavioural priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Jan 27, 2024
@bdach bdach self-assigned this Feb 9, 2024
@bdach bdach moved this from Needs discussion to In Progress in osu! client development focus Feb 13, 2024
@bdach bdach moved this from In Progress to In Review in osu! client development focus Feb 14, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in osu! client development focus Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:1 Very important. Feels bad without fix. Affects the majority of users. type:behavioural type:online
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants