Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manager "check again after x minutes" should be centralised #23635

Open
peppy opened this issue May 23, 2023 · 0 comments
Open

Update manager "check again after x minutes" should be centralised #23635

peppy opened this issue May 23, 2023 · 0 comments
Labels
priority:1 Very important. Feels bad without fix. Affects the majority of users. type:code-quality

Comments

@peppy
Copy link
Member

peppy commented May 23, 2023

Currently this is implemented locally in SquirrelUpdateManager:

if (scheduleRecheck)
{
// check again in 30 minutes.
Scheduler.AddDelayed(() => Task.Run(async () => await checkForUpdateAsync().ConfigureAwait(false)), 60000 * 30);
}

But this really should be managed at a higher level.

@peppy peppy added type:code-quality priority:1 Very important. Feels bad without fix. Affects the majority of users. labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:1 Very important. Feels bad without fix. Affects the majority of users. type:code-quality
Projects
None yet
Development

No branches or pull requests

1 participant