Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random mod with non-star effect mod (visually) change star rating. #13453

Open
IkaWaAyuMu opened this issue Jun 11, 2021 · 4 comments
Open

Random mod with non-star effect mod (visually) change star rating. #13453

IkaWaAyuMu opened this issue Jun 11, 2021 · 4 comments
Labels

Comments

@IkaWaAyuMu
Copy link

Describe the bug: When selecting random mod with other mod that doesn't effect the star rating, the star rating keep changing but stay same with same mod combination. I don't know the actual effect though, I don't know how to check.

I think the Random mod shouldn't effect star rating in any mean, but I don't know what actually behind it :P

Screenshots or videos showing encountered issue:

2021-06-11.18-20-34_Trim.mp4

osu!lazer version: 2021.608.0

Logs:
database.log
network.log
performance.log
performance-audio.log
performance-draw.log
performance-update.log
runtime.log
updater.log

@peppy
Copy link
Member

peppy commented Jun 11, 2021

Known issue, as it is calculating each random generation. Also not a huge issue. I'm sure you and other users can understand why it's happening, right?

Not even sure if this is worth tracking/fixing to be honest, but let's see what others say.

May be more suited to a discussion.

@peppy peppy added area:mods priority:3 Nice to have, at some point type:behavioural labels Jun 11, 2021
@bdach
Copy link
Collaborator

bdach commented Jun 11, 2021

I think the Random mod shouldn't effect star rating in any mean, but I don't know what actually behind it :P

It very much should affect the star rating. Because the map changes. The objects on it are in a different place.

I also think this is not important enough to realistically matter. May be fine to fix the seed until play start at the most.

@okolenmi
Copy link

okolenmi commented Oct 7, 2024

I think, peppy and bdach didn't undersand the problem. I have 500pp unranked score on a Hard difficulty map, for example:
osu_2024-10-07_20-33-47

It was easy, but the game calculated it as 8.65*. It's a problem of star rating calculation.

@bdach
Copy link
Collaborator

bdach commented Oct 7, 2024

@okolenmi your issue is #29729, is a recent regression, and is fixed already (fix will be released shortly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants