Max combo is not marked correctly in green on some taiko beatmaps

[bdach]

Reported to me externally.

Examples:

• https://osu.ppy.sh/beatmapsets/2081945#taiko/4364483 - no green combos at all
• https://osu.ppy.sh/beatmapsets/2101463#taiko/4427354 - half and half

This is unverified yet but the chain of failure is likely:

• https://github.com/ppy/osu/blob/1575eed5ba5216ff56861099a7445a1b6b98a6fa/osu.Game.Rulesets.Taiko/Difficulty/TaikoLegacyScoreSimulator.cs (code calculating scoring attributes) wrongly considers strong drum rolls as counting for double combo
• From the incorrect max combo, https://github.com/ppy/osu-queue-score-statistics/blob/784bc89d1debae64a74c9f45e688db10f30ebb17/osu.Server.Queues.ScoreStatisticsProcessor/Commands/Queue/BatchInserter.cs#L337 puts in legacy_combo_increase in maximum_statistics on taiko scores that should not be there
• Thus logic in

  osu-web/app/Models/Solo/Score.php

  Lines 319 to 322 in 623459f

  	public function isPerfectCombo(): bool
  	{
  	return $this->passed && $this->max_combo === $this->maxAchievableCombo();
  	}

  determines the score to not have max combo

Steps for corrective action:

Tasks

Preview Give feedback

1. Fix strong drum rolls being counted for double the combo in legacy scoring attributes osu#30917
   area:scoring ruleset/osu!taiko size/XS +3
   
2. Recompute scoring attributes for all taiko beatmaps
3. Add capability to verify maximum statistics of scores osu-queue-score-statistics#306
   size/M +1
   
4. Reverify maximum_statistics on all taiko scores to fix the incorrect legacy_combo_increase

[bdach]

Looks fixed now.