Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mania scores that are SS on classic are not SS on lazer mode #10990

Closed
tailsdk opened this issue Feb 11, 2024 · 4 comments
Closed

Some mania scores that are SS on classic are not SS on lazer mode #10990

tailsdk opened this issue Feb 11, 2024 · 4 comments
Labels
area:scoring external component Doesn't really belong to osu-web but there's nowhere else to move the issue to

Comments

@tailsdk
Copy link
Contributor

tailsdk commented Feb 11, 2024

I dont know if this is only a problem for newer scores but not all SS scores on classic mod show as SS on lazer mode as an example https://osu.ppy.sh/scores/2322006466 and https://osu.ppy.sh/scores/2298997490 are both SS but only show up as S ranks on lazer mode

@cl8n
Copy link
Member

cl8n commented Feb 11, 2024

I think that's actually intended right now; in "lazer mode" scores and ranks use the lazer rules, even if the score came from stable

@tailsdk
Copy link
Contributor Author

tailsdk commented Feb 11, 2024

But those scores should also be SS on lazer see the 2 scores below on https://osu.ppy.sh/beatmapsets/1335568#mania/2766889 which just have a worse ratio but are SS

@nanaya nanaya added the external component Doesn't really belong to osu-web but there's nowhere else to move the issue to label Feb 11, 2024
@nanaya
Copy link
Collaborator

nanaya commented Feb 11, 2024

fwiw, the lazer version of rank comes directly from score processor (and stored in database), not computed by osu-web

@bdach
Copy link
Contributor

bdach commented Mar 21, 2024

For better or for worse the inconsistency looks fixed now, likely by one of the rank recomputation round(s) that we ran.

I'm not going to speak on whether it got fixed in the 'correct' direction, since lazer SS is all PERFECTs currently, but that conversation can continue if needed under ppy/osu#24238.

@bdach bdach closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scoring external component Doesn't really belong to osu-web but there's nowhere else to move the issue to
Projects
None yet
Development

No branches or pull requests

4 participants