Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

friendsofphp/php-cs-fixer old version #61

Open
gemal opened this issue Apr 28, 2017 · 8 comments
Open

friendsofphp/php-cs-fixer old version #61

gemal opened this issue Apr 28, 2017 · 8 comments

Comments

@gemal
Copy link

gemal commented Apr 28, 2017

in https://github.com/potsky/laravel-localization-helpers/blob/5.0/composer.json

you have:

            "require": {
                "friendsofphp/php-cs-fixer": "^1.11",

shouldn't that be moved to require-dev?

@potsky
Copy link
Owner

potsky commented Apr 28, 2017

Hi @gemal,

nice to see you on a an other repo ;-)

This package is required to generate lang files according to your code style. So this is not a dev requirement. It is used according to the code_style option in configuration file.

But my package should be used as a dev requirement given that it is only a developer helper.

@potsky potsky closed this as completed Apr 28, 2017
@gemal
Copy link
Author

gemal commented Apr 28, 2017

I have "potsky/laravel-localization-helpers" in "require-dev"

can you dump the version of it?

@potsky
Copy link
Owner

potsky commented Apr 28, 2017

What do you mean by dumping the version of it ? If you talk about the version you need to use, it depends of course of your laravel version.

@gemal
Copy link
Author

gemal commented Apr 28, 2017

sorry meant bumping the version of friendsofphp/php-cs-fixer to the newest version

@gemal
Copy link
Author

gemal commented May 12, 2017

composer require --dev friendsofphp/php-cs-fixer
Using version ^2.3 for friendsofphp/php-cs-fixer
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - potsky/laravel-localization-helpers v2.5.5 requires friendsofphp/php-cs-fixer ^1.11 -> satisfiable by friendsofphp/php-cs-fixer[1.13.x-dev, v1.11, v1.11.1, v1.11.2, v1.11.3, v1.11.4, v1.11.5, v1.11.6, v1.11.7, v1.11.8, v1.12.0, v1.12.1, v1.12.2, v1.12.3, v1.12.4, v1.13.0, v1.13.1] but these conflict with your requirements or minimum-stability.
    - potsky/laravel-localization-helpers v2.5.5 requires friendsofphp/php-cs-fixer ^1.11 -> satisfiable by friendsofphp/php-cs-fixer[1.13.x-dev, v1.11, v1.11.1, v1.11.2, v1.11.3, v1.11.4, v1.11.5, v1.11.6, v1.11.7, v1.11.8, v1.12.0, v1.12.1, v1.12.2, v1.12.3, v1.12.4, v1.13.0, v1.13.1] but these conflict with your requirements or minimum-stability.
    - potsky/laravel-localization-helpers v2.5.5 requires friendsofphp/php-cs-fixer ^1.11 -> satisfiable by friendsofphp/php-cs-fixer[1.13.x-dev, v1.11, v1.11.1, v1.11.2, v1.11.3, v1.11.4, v1.11.5, v1.11.6, v1.11.7, v1.11.8, v1.12.0, v1.12.1, v1.12.2, v1.12.3, v1.12.4, v1.13.0, v1.13.1] but these conflict with your requirements or minimum-stability.
    - Installation request for potsky/laravel-localization-helpers (locked at v2.5.5, required as 2.5.*) -> satisfiable by potsky/laravel-localization-helpers[v2.5.5].


Installation failed, reverting ./composer.json to its original content.

I cant install the newest friendsofphp/php-cs-fixer into my project :(

@potsky
Copy link
Owner

potsky commented May 15, 2017

Hi @gemal,

can you modify my composer.json requirement about friendsofphp/php-cs-fixer and set it to ^2.3 ? Does it still works ?

@potsky potsky reopened this May 15, 2017
@potsky
Copy link
Owner

potsky commented May 15, 2017

Let down... The way CSFixer works has changed... I need to read the doc and implement the new format.

@gemal
Copy link
Author

gemal commented May 15, 2017

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants