fix automatic filter bandwidth selection #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in
setBandwidth()
in which a value of zero would be turned into a nonzero value byhackrf_compute_baseband_filter_bw()
. This made(_current_bandwidth > 0)
always true, resulting in the baseband filter bandwidth being set to the minimum (nominally 1.75 MHz) instead of being automatic. AlthoughsetSampleRate()
did set automatic filter bandwidth correctly, it was subsequently set incorrectly bysetBandwidth()
.I removed the call to
hackrf_compute_baseband_filter_bw()
ashackrf_set_baseband_filter_bandwidth()
does this for you.I also removed the automatic bandwidth filter setting in
setSampleRate()
ashackrf_set_sample_rate()
does this for you.