Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update flask/werkzeug requirements #624

Open
jvanasco opened this issue Oct 20, 2020 · 0 comments · May be fixed by #638
Open

update flask/werkzeug requirements #624

jvanasco opened this issue Oct 20, 2020 · 0 comments · May be fixed by #638

Comments

@jvanasco
Copy link

setup.py requires an unversioned Flask and werkzeug>=0.14

There have been some breaking changes from flask and werkzeug regarding the Request.is_xhr attribute ( see https://github.com/pallets/flask/search?q=is_xhr&type=issues )

While the latest versions are compatible and can be upgraded by users, it would be nice if httpbin updated setup.py to use the current minimal versions - as this can break CI tests if an outdated version of either is picked up.
@Aayush-hub Aayush-hub linked a pull request Mar 17, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solved Conflicts Aayush-hub/httpbin
1 participant
@jvanasco