Skip to content

Commit

Permalink
feat: vox custom parser (#67)
Browse files Browse the repository at this point in the history
  • Loading branch information
janetleekim authored and adampash committed Dec 16, 2016
1 parent a710efd commit 3cf2bb7
Show file tree
Hide file tree
Showing 4 changed files with 157 additions and 0 deletions.
1 change: 1 addition & 0 deletions fixtures/www.vox.com/1481563623532.html

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/extractors/custom/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ export * from './www.theguardian.com';
export * from './www.sbnation.com';
export * from './www.bloomberg.com';
export * from './www.bustle.com';
export * from './www.vox.com';
58 changes: 58 additions & 0 deletions src/extractors/custom/www.vox.com/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
export const WwwVoxComExtractor = {
domain: 'www.vox.com',

title: {
selectors: [
'h1.c-page-title',
],
},

author: {
selectors: [
['meta[name="author"]', 'value'],
],
},

date_published: {
selectors: [
['meta[name="article:published_time"]', 'value'],
],
},

dek: {
selectors: [
'.p-dek',
],
},

lead_image_url: {
selectors: [
['meta[name="og:image"]', 'value'],
],
},

content: {
selectors: [
['figure.e-image--hero', '.c-entry-content'],
'.c-entry-content',
],

// Is there anything in the content you selected that needs transformed
// before it's consumable content? E.g., unusual lazy loaded images
transforms: {
'figure .e-image__image noscript': ($node) => {
const imgHtml = $node.html();
$node.parents('.e-image__image').find('.c-dynamic-image').replaceWith(imgHtml);
},

'figure .e-image__meta': 'figcaption',
},

// Is there anything that is in the result that shouldn't be?
// The clean selectors will remove anything that matches from
// the result
clean: [

],
},
};
97 changes: 97 additions & 0 deletions src/extractors/custom/www.vox.com/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
import assert from 'assert';
import fs from 'fs';
import URL from 'url';
import cheerio from 'cheerio';

import Mercury from 'mercury';
import getExtractor from 'extractors/get-extractor';
import { excerptContent } from 'utils/text';

describe('WwwVoxComExtractor', () => {
describe('initial test case', () => {
let result;
let url;
beforeAll(() => {
url =
'http://www.vox.com/culture/2016/12/10/13898352/trump-twitter-harassment-policy-bannable';
const html =
fs.readFileSync('./fixtures/www.vox.com/1481563623532.html');
result =
Mercury.parse(url, html, { fallback: false });
});

it('is selected properly', () => {
// This test should be passing by default.
// It sanity checks that the correct parser
// is being selected for URLs from this domain
const extractor = getExtractor(url);
assert.equal(extractor.domain, URL.parse(url).hostname);
});

it('returns the title', async () => {
// To pass this test, fill out the title selector
// in ./src/extractors/custom/www.vox.com/index.js.
const { title } = await result;

// Update these values with the expected values from
// the article.
assert.equal(title, 'Donald Trump’s tweets fit a pattern of harassment Twitter has banned before');
});

it('returns the author', async () => {
// To pass this test, fill out the author selector
// in ./src/extractors/custom/www.vox.com/index.js.
const { author } = await result;

// Update these values with the expected values from
// the article.
assert.equal(author, 'Aja Romano');
});

it('returns the date_published', async () => {
// To pass this test, fill out the date_published selector
// in ./src/extractors/custom/www.vox.com/index.js.
const { date_published } = await result;

// Update these values with the expected values from
// the article.
assert.equal(date_published, '2016-12-10T15:20:01.000Z');
});

it('returns the dek', async () => {
// To pass this test, fill out the dek selector
// in ./src/extractors/custom/www.vox.com/index.js.
const { dek } = await result;

// Update these values with the expected values from
// the article.
assert.equal(dek, 'The President-elect’s targets may endure real-life threats from hordes of his supporters.');
});

it('returns the lead_image_url', async () => {
// To pass this test, fill out the lead_image_url selector
// in ./src/extractors/custom/www.vox.com/index.js.
const { lead_image_url } = await result;

// Update these values with the expected values from
// the article.
assert.equal(lead_image_url, 'https://cdn0.vox-cdn.com/thumbor/RuJTDlBH9LAp_9uFqYfnPzWXhj0=/0x175:2500x1564/1080x600/cdn0.vox-cdn.com/uploads/chorus_image/image/52223131/628656068.0.jpeg');
});

it('returns the content', async () => {
// To pass this test, fill out the content selector
// in ./src/extractors/custom/www.vox.com/index.js.
// You may also want to make use of the clean and transform
// options.
const { content } = await result;

const $ = cheerio.load(content || '');

const first13 = excerptContent($('*').first().text(), 13);

// Update these values with the expected values from
// the article.
assert.equal(first13, 'Photo by Steve Pope/Getty Images After the election, Twitter issued a statement to');
});
});
});

0 comments on commit 3cf2bb7

Please sign in to comment.