JSPM Lookups #194
JSPM Lookups #194
Conversation
| @@ -23,7 +24,7 @@ module.exports = function(id, base, options) { | |||
| basedir: base, | |||
| moduleDirectory: moduleDirectories, | |||
| paths: paths, | |||
| extensions: [ ".css" ], | |||
| extensions: [ ".css", ".sss" ], | |||
There was a problem hiding this comment.
Please don't add this. You can handle this via option.
There was a problem hiding this comment.
Okay, I'll change it back.
|
I reduced the integration for jspm a bit. This was mainly a try to solve the test puzzle for jspm. The current versions seems to be the minimum viable one to add jspm packages resolving... |
| "./lib/resolve-id": "@empty" | ||
| }, | ||
| "dependencies": {}, | ||
| "devDependencies": {} |
There was a problem hiding this comment.
are the empty field required?
There was a problem hiding this comment.
You are really caring about the details, are you? - That's welcome.
There was a problem hiding this comment.
I will try with leaving them out...
|
Looks good without dependencies and devDependencies. |
|
Would it be possible to merge this into master and do a new release? Or is there anything outstanding we have to work before this could happen? |
|
Released as 8.1.1 |
|
Adding
Also it seems a slight shame that adding jspm support means that all users have the additional complexity overhead of the jspm modules added to their dependency trees, even if they don't use jspm ... hence problems like the above ... |
|
I think we should move this to peerDependencies and only import in a jspm context. Will open an issue about that. |
|
@swernerx any thoughts about the security issues? |
|
I use postcss-import in webpack postcss-loader |
Added support for JSPM based lookups.
I have not yet any tests for jspm lookup in this package, but in the origin/dependency project (would require some jspm installs which I am not sure should be done here).