Add JSPM browser field #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add @empty statements for load-content and resolve-id so that their deps aren't loaded in browser environment. This allows for JSPM to not error out. Custom resolve/load functions will need to be provided as options for proper functionality.
|
Can you squash to a single commit please? |
|
ping |
|
You should be able to do that with the new squash + merge ability on GitHub, yeah? I can clean it up if you'd prefer, though. https://github.com/blog/2141-squash-your-commits |
|
@MeoMix yeah :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @empty statements for load-content and resolve-id so that their deps aren't loaded in browser environment. This allows for JSPM to not error out. Custom resolve/load functions will need to be provided as options for proper functionality.
(New PR cuz I'm a terrible Git wizard and failed to squash properly after a few attempts.)