Refactor path resolve #116
Conversation
| root: ".", | ||
| }) | ||
| }) | ||
|
|
There was a problem hiding this comment.
Why did you remove this test(s)?
Looks pretty important to me.
|
@MoOx What is the case of local npm modules? |
|
web_modules with webpack :) |
|
Note that I think this also cover node_modules. |
|
@MoOx package.json in node_modules or web_modules still works. But it doesn't work in local directories. Also I removed bower_components, caz we still do not support bower.json |
|
@MoOx Okay I saved previous way to resolve paths. |
| @@ -18,7 +18,6 @@ var resolveMedia = require("./lib/resolve-media") | |||
| var moduleDirectories = [ | |||
| "web_modules", | |||
| "node_modules", | |||
| "bower_components", | |||
There was a problem hiding this comment.
This should be added in the CHANGELOG since it's a breaking changes (and we should add how to add bower support like it was).
|
@MoOx Done! |
|
Is PR too big or you can accept it? |
| @@ -1,5 +1,9 @@ | |||
| - Removed: async mode/option | |||
| ([#107](https://github.com/postcss/postcss-import/pull/107)) | |||
| - Removed: bower is not currently supported, use custom resolver | |||
| ([#116](https://github.com/postcss/postcss-import/pull/116)) | |||
There was a problem hiding this comment.
fyi, you can just add bower support by it to the path option.
So I would use "bower_components" not supported by default anymore, use "path" option to add it back.
There was a problem hiding this comment.
bower support is also bower.json support, which is not simple with main field as array.
There was a problem hiding this comment.
I know that, but bower is more a downloader, so I guess lots of people just point to the right css file when they import it (eg: @import "jquery-slider-fx-2016/slider.css") so we don't really care about it. The idea is just to inform people that are currently using the feature we are breaking how to upgrade easily.
|
@TrySound Except my last comments about the CHANGELOG, this PR looks good. Great job. I just want to be sure that the developer experience for upgrading is easy :D |
|
@MoOx Done |
|
👍 |
No description provided.